[bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.

[bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.

[Danny Milosavljevic]

* gnu/packages/linux.scm (make-linux-libre): Use invoke.
---
 gnu/packages/linux.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 858f0885c..e01edce9c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -336,7 +336,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                    (begin
                      (copy-file config ".config")
                      (chmod ".config" #o666))
-                   (system* "make" ,defconfig))
+                   (invoke "make" ,defconfig))
 
                ;; Appending works even when the option wasn't in the
                ;; file.  The last one prevails if duplicated.
@@ -345,7 +345,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                  (display extra-configuration port)
                  (close-port port))
 
-               (zero? (system* "make" "oldconfig")))))
+               (invoke "make" "oldconfig"))))
          (replace 'install
            (lambda* (#:key inputs native-inputs outputs #:allow-other-keys)
              (let* ((out    (assoc-ref outputs "out"))
@@ -360,13 +360,13 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                          (find-files "." "\\.dtb$"))
                ;; Install kernel modules
                (mkdir-p moddir)
-               (zero? (system* "make"
-                               (string-append "DEPMOD=" kmod "/bin/depmod")
-                               (string-append "MODULE_DIR=" moddir)
-                               (string-append "INSTALL_PATH=" out)
-                               (string-append "INSTALL_MOD_PATH=" out)
-                               "INSTALL_MOD_STRIP=1"
-                               "modules_install"))))))
+               (invoke "make"
+                       (string-append "DEPMOD=" kmod "/bin/depmod")
+                       (string-append "MODULE_DIR=" moddir)
+                       (string-append "INSTALL_PATH=" out)
+                       (string-append "INSTALL_MOD_PATH=" out)
+                       "INSTALL_MOD_STRIP=1"
+                       "modules_install")))))
        #:tests? #f))
     (home-page "https://www.gnu.org/software/linux-libre/")
     (synopsis "100% free redistribution of a cleaned Linux kernel")

[bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote:
> * gnu/packages/linux.scm (make-linux-libre): Use invoke.

Thanks!

This will require rebuilding linux-libre, right? If so, we should push
it along with updates to those packages.

CC-ing Mark, who usually handles linux-libre.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.

[Mark H Weaver]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote:
>> * gnu/packages/linux.scm (make-linux-libre): Use invoke.
>
> Thanks!
>
> This will require rebuilding linux-libre, right? If so, we should push
> it along with updates to those packages.

Agreed.  I'll try to remember to push Danny's commit the next time I
push kernel updates, which typically happen every few days anyway.
Let's hold off on this until then.

     Thanks!
       Mark

bug#30454: [PATCH] gnu: make-linux-libre: Use invoke.

[Mark H Weaver]

I just pushed Danny's commit to master along with kernel updates, commit
fdd400d82ed83e230331f837aee70e1d504fe58c.  I'm marking this as done.

     Thanks!
       Mark