From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 45948@debbugs.gnu.org
Subject: [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver.
Date: Sat, 30 Jan 2021 22:34:49 +0100 [thread overview]
Message-ID: <87eei2p0qu.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210118062501.27022-5-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 18 Jan 2021 01:25:00 -0500")
Hi!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> * build-aux/test-driver.scm (show-help): Add help text for the new --select
> and --exclude options.
> (%options): Add the new select and exclude options.
> (test-runner-gnu): Pass them to the test runner. Update doc.
> (test-match-name*, test-match-name*/negated, %test-match-all): New variables.
> (main): Compute the test specifier based on the values of the new options and
> apply it to the current test runner when running the test file.
> * doc/guix.texi (Running the Test Suite): Document the new options.
I never felt the need for this since most individual files run quickly
enough (and those that don’t should be optimized…), but it can be
useful.
> +;;; XXX: test-match-all is a syntax, which isn't convenient to use with a list
> +;;; of test specifiers computed at run time.
> +(define %test-match-all (@@ (srfi srfi-64) %test-match-all))
Since this is an internal procedure in Guile that could vanish anytime,
I recommend copying it here (it’s just 9 lines).
> +The underlying SRFI 64 custom Automake test driver used for the 'check'
> +test suite (located at @file{build-aux/test-driver.scm}) also allows
Maybe shorten to “The underlying test driver (located at
@file{build-aux/test-driver.scm}) also allows”.
I didn’t test it, but it otherwise LGTM.
Ludo’.
next prev parent reply other threads:[~2021-01-30 21:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 6:18 [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Maxim Cournoyer
2021-01-18 6:24 ` [bug#45948] [PATCH 1/5] build: test-driver.scm Make output redirection optional Maxim Cournoyer
2021-01-18 6:24 ` [bug#45948] [PATCH 2/5] build: test-driver.scm: Define the --test-name option as required Maxim Cournoyer
2021-01-18 14:37 ` [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Maxim Cournoyer
2021-01-18 6:24 ` [bug#45948] [PATCH 3/5] build: test-driver.scm: Enable colored test results by default Maxim Cournoyer
2021-01-30 21:39 ` [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Ludovic Courtès
2021-02-01 2:47 ` Maxim Cournoyer
2021-01-18 6:24 ` [bug#45948] [PATCH 4/5] build: test-driver.scm: Add test cases filtering options Maxim Cournoyer
2021-01-18 14:38 ` [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Maxim Cournoyer
2021-01-18 6:25 ` [bug#45948] [PATCH 4/5] build: test-driver.scm: Provide the ability to filter on test case names Maxim Cournoyer
2021-01-30 21:34 ` Ludovic Courtès [this message]
2021-02-01 3:44 ` bug#45948: [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Maxim Cournoyer
2021-01-18 6:25 ` [bug#45948] [PATCH 5/5] build: test-driver.scm: Add a new '--errors-only' option Maxim Cournoyer
2021-01-30 21:32 ` [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver Ludovic Courtès
2021-02-01 22:18 ` Ludovic Courtès
2021-02-02 5:47 ` Maxim Cournoyer
2021-02-02 8:36 ` zimoun
2021-02-02 12:52 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eei2p0qu.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=45948@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).