From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id jxhNJBXRFWCjZAAA0tVLHw (envelope-from ) for ; Sat, 30 Jan 2021 21:35:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MPxoHxXRFWAbPgAAbx9fmQ (envelope-from ) for ; Sat, 30 Jan 2021 21:35:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41475940415 for ; Sat, 30 Jan 2021 21:35:17 +0000 (UTC) Received: from localhost ([::1]:56482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5xtk-0008V0-6f for larch@yhetil.org; Sat, 30 Jan 2021 16:35:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5xtY-0008Us-5O for guix-patches@gnu.org; Sat, 30 Jan 2021 16:35:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5xtV-0006wo-MH for guix-patches@gnu.org; Sat, 30 Jan 2021 16:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5xtV-0007cT-K5 for guix-patches@gnu.org; Sat, 30 Jan 2021 16:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 Jan 2021 21:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45948 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 45948-submit@debbugs.gnu.org id=B45948.161204249929277 (code B ref 45948); Sat, 30 Jan 2021 21:35:01 +0000 Received: (at 45948) by debbugs.gnu.org; 30 Jan 2021 21:34:59 +0000 Received: from localhost ([127.0.0.1]:55925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5xtS-0007c8-ND for submit@debbugs.gnu.org; Sat, 30 Jan 2021 16:34:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5xtQ-0007bt-Ut for 45948@debbugs.gnu.org; Sat, 30 Jan 2021 16:34:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51673) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5xtL-0006su-E3; Sat, 30 Jan 2021 16:34:51 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48878 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l5xtL-0000I8-2N; Sat, 30 Jan 2021 16:34:51 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210118062501.27022-1-maxim.cournoyer@gmail.com> <20210118062501.27022-5-maxim.cournoyer@gmail.com> Date: Sat, 30 Jan 2021 22:34:49 +0100 In-Reply-To: <20210118062501.27022-5-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 18 Jan 2021 01:25:00 -0500") Message-ID: <87eei2p0qu.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45948@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 41475940415 X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: cG1xy5n0/xQq Hi! Maxim Cournoyer skribis: > * build-aux/test-driver.scm (show-help): Add help text for the new --sele= ct > and --exclude options. > (%options): Add the new select and exclude options. > (test-runner-gnu): Pass them to the test runner. Update doc. > (test-match-name*, test-match-name*/negated, %test-match-all): New variab= les. > (main): Compute the test specifier based on the values of the new options= and > apply it to the current test runner when running the test file. > * doc/guix.texi (Running the Test Suite): Document the new options. I never felt the need for this since most individual files run quickly enough (and those that don=E2=80=99t should be optimized=E2=80=A6), but it = can be useful. > +;;; XXX: test-match-all is a syntax, which isn't convenient to use with = a list > +;;; of test specifiers computed at run time. > +(define %test-match-all (@@ (srfi srfi-64) %test-match-all)) Since this is an internal procedure in Guile that could vanish anytime, I recommend copying it here (it=E2=80=99s just 9 lines). > +The underlying SRFI 64 custom Automake test driver used for the 'check' > +test suite (located at @file{build-aux/test-driver.scm}) also allows Maybe shorten to =E2=80=9CThe underlying test driver (located at @file{build-aux/test-driver.scm}) also allows=E2=80=9D. I didn=E2=80=99t test it, but it otherwise LGTM. Ludo=E2=80=99.