unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Hilton Chain <hako@ultrarare.space>
Cc: 58887@debbugs.gnu.org
Subject: [bug#58887] [PATCH][staging] gnu: vulkan-loader: Add native-search-paths field.
Date: Thu, 01 Dec 2022 16:49:37 +0100	[thread overview]
Message-ID: <87edtjyvhq.fsf@gnu.org> (raw)
In-Reply-To: <y765yg1hnql.wl-hako@ultrarare.space> (Hilton Chain's message of "Sun, 30 Oct 2022 13:41:38 +0800")

Hi,

Hilton Chain <hako@ultrarare.space> skribis:

> * gnu/packages/vulkan.scm (vulkan-loader): Add native-search-paths field.
> [source]: Change ICD and implicit layers looking up behaviour via snippet.

One comment:

[...]

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "VK_ICD_PATH")
> +            (files '("share/vulkan/icd.d")))
> +           (search-path-specification
> +            (variable "VK_ILAYER_PATH")
> +            (files '("share/vulkan/implicit_layer.d")))))

Should these read “lib” rather than “share”, given that they contain
binaries if I’m not mistaken?

Should it be versioned too, like “lib/vulkan/3.0/icd.d”?

Other than that it LGTM.

Thanks,
Ludo’.




  reply	other threads:[~2022-12-01 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  5:41 [bug#58887] [PATCH][staging] gnu: vulkan-loader: Add native-search-paths field Hilton Chain via Guix-patches via
2022-12-01 15:49 ` Ludovic Courtès [this message]
2022-12-23  7:53   ` Hilton Chain via Guix-patches via
2023-06-18 16:31 ` Kaelyn via Guix-patches via
2023-06-19  6:14   ` bug#58887: " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edtjyvhq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=58887@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).