From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GOdoOFrNiGPfngAAbAwnHQ (envelope-from ) for ; Thu, 01 Dec 2022 16:50:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cFqEOFrNiGOf6AAA9RJhRA (envelope-from ) for ; Thu, 01 Dec 2022 16:50:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C47D012EF5 for ; Thu, 1 Dec 2022 16:50:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0lpU-0004YJ-Sz; Thu, 01 Dec 2022 10:50:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0lp6-0004UZ-KA for guix-patches@gnu.org; Thu, 01 Dec 2022 10:50:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0lp4-0007l6-4L for guix-patches@gnu.org; Thu, 01 Dec 2022 10:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0lp3-0000Wb-Vh for guix-patches@gnu.org; Thu, 01 Dec 2022 10:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58887] [PATCH][staging] gnu: vulkan-loader: Add native-search-paths field. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Dec 2022 15:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58887 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: 58887@debbugs.gnu.org Received: via spool by 58887-submit@debbugs.gnu.org id=B58887.16699097851936 (code B ref 58887); Thu, 01 Dec 2022 15:50:01 +0000 Received: (at 58887) by debbugs.gnu.org; 1 Dec 2022 15:49:45 +0000 Received: from localhost ([127.0.0.1]:40435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0lom-0000V9-V3 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 10:49:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0lom-0000UX-29 for 58887@debbugs.gnu.org; Thu, 01 Dec 2022 10:49:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0log-0007g0-R6; Thu, 01 Dec 2022 10:49:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+EEu8Ic5+5slG8tL0Ve2api4P2vVGZKik3TH96bR7cY=; b=CWPsd4rrxZ/b074ob+xe z7VbT7zrxX4g0htUcAr0vDP0GJIuTAPjZl0IPsuYf7I3gUWnagfwukkyKHcExfbV/otl4LJryd7yF +ts720HxA41TkF6rReFCBDuclQ4+GeNWlj3GR9Vybb9QWC7rLPfPe/qy0qRGlWuZea/6OG0KuKmqY dOB6zJE0NhOKKY0uE7pfD1weQogJZa312QmO8tx6/WVSjmWneK4e0pGub3iDTgo/d3Ps3CzJvn7YI In1uCAcTLYgzsatLYA2ZqcEXR5vUvbheDClZVgFjwlHTh4DKtSGJoq6k+vFFZL1yvClbaZe0PSDEE lhGbOwW4iAE+lA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0log-0002V2-Bh; Thu, 01 Dec 2022 10:49:38 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 01 Dec 2022 16:49:37 +0100 In-Reply-To: (Hilton Chain's message of "Sun, 30 Oct 2022 13:41:38 +0800") Message-ID: <87edtjyvhq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669909850; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+EEu8Ic5+5slG8tL0Ve2api4P2vVGZKik3TH96bR7cY=; b=Jo8eYmIEqxDKEtbt2hyUn1vvZDOcTn17+dTzPV8Xgi+2rvaPRWfz/XKP3e5hsn+5YIalGI TVxEkneY+WetkHTdgw+5J3Ouzsv1XlPDJYitzoBVUhAxoM0Mp3JcEpdb2cNeuzlg+gwqYc 6tiGGOY8qc/c5zxHEdmqH92oJ/HIGOl+nSeyykEeDWNvkhaAx02XDw9zUAOGI5al+vXeDT INd2i0gEOuK9mS9leT6fBSlPSMxfJU0TsvUIIP7O+xlqh6Kok0XCIZ6SNHlxiPWtBPcLl4 1pD4I7mnS8qv87NXhVYlVdMi3D63X02O07Xv+hCEDTJpBj8ZTJQm4OZF2sewfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669909850; a=rsa-sha256; cv=none; b=izZTbdU7NQIGoqRtSN+RsycDUDaWHFu0A5e1E8iXIgKK7g/nqbA7JakGlw88nj41hd3+i8 FXCSkJE/x+GRf2VyCNTsugxwkr8n3PQGPcPSd/p4rEU7Y0RnzMJ2yXkDvUJmPvrMSFTjKV JIl+NYQlRgyWxZ4Uraoe+r8+rClv29xGifynD1aFquv6Tuo8b+aNieiGt3sGWvHJgtSAhu 5KPr71n0NWUKHwF+OyDgg91fQ10olD5Q2tvJQQt+AEa6e4kMWcioymJq7E0tcEsdIxxLh6 svIusdsFgsi6RiblKx61HI+bfdypBxZMOgDBQk8AnUOoV+DvnjygFCIn8lnnqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CWPsd4rr; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CWPsd4rr; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C47D012EF5 X-Spam-Score: -3.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: fpSVuGTF/kyo Hi, Hilton Chain skribis: > * gnu/packages/vulkan.scm (vulkan-loader): Add native-search-paths field. > [source]: Change ICD and implicit layers looking up behaviour via snippet. One comment: [...] > + (native-search-paths > + (list (search-path-specification > + (variable "VK_ICD_PATH") > + (files '("share/vulkan/icd.d"))) > + (search-path-specification > + (variable "VK_ILAYER_PATH") > + (files '("share/vulkan/implicit_layer.d"))))) Should these read =E2=80=9Clib=E2=80=9D rather than =E2=80=9Cshare=E2=80=9D= , given that they contain binaries if I=E2=80=99m not mistaken? Should it be versioned too, like =E2=80=9Clib/vulkan/3.0/icd.d=E2=80=9D? Other than that it LGTM. Thanks, Ludo=E2=80=99.