From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Antero Mejr <antero@mailbox.org>
Cc: lars@6xq.net, 59792@debbugs.gnu.org
Subject: [bug#59792] [PATCH] gnu: Add python-pynetdicom.
Date: Mon, 16 Jan 2023 09:53:09 -0500 [thread overview]
Message-ID: <87edrua5uy.fsf@gmail.com> (raw)
In-Reply-To: <20221203050357.30524-1-antero@mailbox.org> (Antero Mejr's message of "Sat, 3 Dec 2022 05:03:57 +0000")
Hi again,
Antero Mejr <antero@mailbox.org> writes:
> * gnu/packages/python-science.scm (python-pynetdicom): New variable.
> ---
> gnu/packages/python-science.scm | 41 +++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
> index 00bba25a4a..d45bcd9bca 100644
> --- a/gnu/packages/python-science.scm
> +++ b/gnu/packages/python-science.scm
> @@ -1702,6 +1702,47 @@ (define-public python-pydicom
> in a pythonic way.")
> (license license:expat)))
>
> +(define-public python-pynetdicom
> + (package
> + (name "python-pynetdicom")
> + (version "2.0.2")
> + (source (origin
> + (method url-fetch)
> + (uri (pypi-uri "pynetdicom" version))
> + (sha256
> + (base32
> + "0farmgviaarb3f4xn751card3v0lza57vwgl5azxxq65p7li44i3"))))
> + (build-system python-build-system)
> + (arguments
> + (list #:phases #~(modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key tests? #:allow-other-keys)
> + (when tests?
> + (invoke "pytest" "-vv" "-k"
> + ;; network tests, 2977/3283 pass
> + (string-append
> + " not TestFindSCP"
> + " and not TestQRGetServiceClass"
> + " and not TestQRMoveServiceClass"
> + " and not TestStoreSCP"
> + " and not test_ae.py"
> + " and not test_echoscp.py"
> + " and not test_qrscp_echo.py"
> + " and not test_storescp.py"
> + " and not test_pr_level_patient"
> + " and not test_pr_level_series"
> + " and not test_scp_cancelled"))))))))
The same tip as offered earlier should work here too (using
pyproject-build-system and its #:test-flags argument).
> + (native-inputs (list python-pyfakefs python-pytest))
> + (propagated-inputs (list python-pydicom python-sqlalchemy))
> + (home-page "https://github.com/pydicom/pynetdicom")
> + (synopsis "Python implementation of the DICOM networking protocol")
> + (description
> + "@code{pynetdicom} is a Python package that implements the DICOM
> +networking protocol. Working with @code{pydicom}, it allows the easy creation
> +of DICOM @acronym{SCUs,Service Class Users} and
> +@acronym{SCPs,Service Class Providers}.")
> + (license license:expat)))
I'd drop the "Working with @code{pydicom}, " and start the sentence
directly from "It allows the creation of [...]".
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-01-16 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 5:03 [bug#59792] [PATCH] gnu: Add python-pynetdicom Antero Mejr via Guix-patches via
2022-12-03 5:08 ` [bug#59792] [PATCH] gnu: Add python-pydicom Antero Mejr via Guix-patches via
2023-01-16 14:50 ` [bug#59792] [PATCH] gnu: Add python-pynetdicom Maxim Cournoyer
2023-01-16 14:53 ` Maxim Cournoyer [this message]
2024-01-24 0:18 ` bug#59792: " Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrua5uy.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59792@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).