From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30991@debbugs.gnu.org
Subject: [bug#30991] [PATCH v2 2/3] services: Add modem-manager-service-type.
Date: Tue, 04 Sep 2018 15:22:07 +0200 [thread overview]
Message-ID: <87d0ttbdog.fsf@gnu.org> (raw)
In-Reply-To: <87tvswjk8h.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 31 Mar 2018 18:14:06 +0200")
Hello Danny,
ludo@gnu.org (Ludovic Courtès) skribis:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * gnu/services/networking.scm (modem-manager-service-type): New variable.
>> (<modem-manager-configuration>): New variable.
>> (modem-manager-configuration): New procedure.
>> (modem-manager-configuration?): New procedure.
>> * doc/guix.texi (Networking Services): Document it.
>
> LGTM, thanks!
Ping! :-)
I think the only question was about patch 3/3, which adds ModemManager
to ‘%desktop-services’. I’m in favor of dropping patch 3/3, but
regardless patches 1/3 (the variant that moves
‘static-networking-service-type’ to (gnu services base), as we
discussed) and 2/3 can definitely go in!
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-09-04 13:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:28 [bug#30991] [PATCH 0/2] Add ModemManager service Danny Milosavljevic
2018-03-29 18:33 ` [bug#30991] [PATCH 1/2] services: Add modem-manager-service-type Danny Milosavljevic
2018-03-29 18:33 ` [bug#30991] [PATCH 2/2] services: Add ModemManager to '%desktop-services' Danny Milosavljevic
2018-03-29 19:15 ` [bug#30991] [PATCH 0/2] Add ModemManager service Danny Milosavljevic
2018-03-29 22:21 ` [bug#30991] [PATCH v2 0/3] " Danny Milosavljevic
2018-03-29 22:21 ` [bug#30991] [PATCH v2 1/3] services: Move static-networking to (gnu services base) Danny Milosavljevic
2018-03-31 16:13 ` Ludovic Courtès
2018-04-01 8:16 ` Danny Milosavljevic
2018-04-01 9:38 ` Ludovic Courtès
2018-03-29 22:21 ` [bug#30991] [PATCH v2 2/3] services: Add modem-manager-service-type Danny Milosavljevic
2018-03-31 16:14 ` Ludovic Courtès
2018-09-04 13:22 ` Ludovic Courtès [this message]
2018-09-04 19:41 ` Danny Milosavljevic
2018-09-04 20:53 ` Ludovic Courtès
2018-09-04 21:16 ` Danny Milosavljevic
2018-03-31 18:39 ` Björn Höfling
2018-03-29 22:21 ` [bug#30991] [PATCH v2 3/3] services: Add ModemManager to '%desktop-services' Danny Milosavljevic
2018-03-31 16:08 ` Ludovic Courtès
2018-05-01 9:58 ` Danny Milosavljevic
2018-05-06 21:00 ` Ludovic Courtès
2018-05-08 7:04 ` Danny Milosavljevic
2018-05-08 13:35 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0ttbdog.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30991@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).