From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fxBIR-0006EA-Rv
	for guix-patches@gnu.org; Tue, 04 Sep 2018 09:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fxBIM-00064j-Pe
	for guix-patches@gnu.org; Tue, 04 Sep 2018 09:23:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40155)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fxBIM-00064W-Kw
	for guix-patches@gnu.org; Tue, 04 Sep 2018 09:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fxBIM-0006iw-Cw
	for guix-patches@gnu.org; Tue, 04 Sep 2018 09:23:02 -0400
Subject: [bug#30991] [PATCH v2 2/3] services: Add modem-manager-service-type.
Resent-Message-ID: <handler.30991.B30991.153606734125778@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180329222140.21590-1-dannym@scratchpost.org>
	<20180329222140.21590-3-dannym@scratchpost.org>
	<87tvswjk8h.fsf@gnu.org>
Date: Tue, 04 Sep 2018 15:22:07 +0200
In-Reply-To: <87tvswjk8h.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sat, 31 Mar 2018 18:14:06 +0200")
Message-ID: <87d0ttbdog.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30991@debbugs.gnu.org

Hello Danny,

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * gnu/services/networking.scm (modem-manager-service-type): New variable.
>> (<modem-manager-configuration>): New variable.
>> (modem-manager-configuration): New procedure.
>> (modem-manager-configuration?): New procedure.
>> * doc/guix.texi (Networking Services): Document it.
>
> LGTM, thanks!

Ping!  :-)

I think the only question was about patch 3/3, which adds ModemManager
to =E2=80=98%desktop-services=E2=80=99.  I=E2=80=99m in favor of dropping p=
atch 3/3, but
regardless patches 1/3 (the variant that moves
=E2=80=98static-networking-service-type=E2=80=99 to (gnu services base), as=
 we
discussed) and 2/3 can definitely go in!

Thanks,
Ludo=E2=80=99.