unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 32565@debbugs.gnu.org
Subject: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Sun, 16 Sep 2018 22:31:55 +0200	[thread overview]
Message-ID: <87d0tdfakk.fsf@gnu.org> (raw)
In-Reply-To: <87efebad2p.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sun, 02 Sep 2018 15:55:58 -0400")

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:06:28 -0400
> Subject: [PATCH 1/2] gnu: Add python-falcon.
>
> * gnu/packages/python-web.scm (python-falcon): New variable.

[...]

> +    (home-page "https://falconframework.org")
> +    (synopsis
> +     "Unladen web framework for building APIs and app backends")
> +    (description
> +     "Falcon is a bare-metal Python web API framework for building
> +high-performance microservices, app backends, and higher-level frameworks.")

If you could make it a bit less catchy and more concrete (giving example
of actual features), that would be great.  :-)

>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:33:17 -0400
> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>
> * gnu/packages/python-web.scm (python-falcon-cors): New variable.

[...]

> +    (home-page
> +     "https://github.com/lwcolton/falcon-cors")
> +    (synopsis "Falcon CORS middlware")
                                  ^^
Typo.

What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?

> +    (description "This middleware provides CORS support for Falcon.")

Ditto here, and bonus points if you add a couple of sentences to explain
what it does concretely.  :-)

Last point: unless you need them, you can remove the “python2-” variants
since Python 2.x is reaching end-of-life.

OK to push with changes along these lines.

Thank you!

Ludo’.

  reply	other threads:[~2018-09-16 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  4:10 [bug#32565] [PATCH] Add python-falcon Maxim Cournoyer
     [not found] ` <handler.32565.B.153551583314214.ack@debbugs.gnu.org>
2018-08-29  4:36   ` [bug#32565] [PATCH] Add python-falcon-cors Maxim Cournoyer
2018-08-30 13:29     ` [bug#32565] [PATCHv2] Add python-falcon and python-falcon-cors Maxim Cournoyer
2018-09-02 19:55     ` [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors Maxim Cournoyer
2018-09-16 20:31       ` Ludovic Courtès [this message]
2018-10-12 13:18         ` Ludovic Courtès
2018-10-15  2:58         ` bug#32565: " Maxim Cournoyer
2018-10-15  7:55           ` [bug#32565] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0tdfakk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=32565@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).