From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g1dj5-00039e-Qm
	for guix-patches@gnu.org; Sun, 16 Sep 2018 16:33:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g1dj4-00009L-Pe
	for guix-patches@gnu.org; Sun, 16 Sep 2018 16:33:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38083)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1g1dj4-000094-Gh
	for guix-patches@gnu.org; Sun, 16 Sep 2018 16:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g1dj4-0004HA-Ce
	for guix-patches@gnu.org; Sun, 16 Sep 2018 16:33:02 -0400
Subject: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Resent-Message-ID: <handler.32565.B32565.153712992514387@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87va7tak4m.fsf@apteryx.i-did-not-set--mail-host-address--so-tickle-me>
	<handler.32565.B.153551583314214.ack@debbugs.gnu.org>
	<87r2ihaiw6.fsf_-_@gmail.com> <87efebad2p.fsf_-_@gmail.com>
Date: Sun, 16 Sep 2018 22:31:55 +0200
In-Reply-To: <87efebad2p.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sun,
	02 Sep 2018 15:55:58 -0400")
Message-ID: <87d0tdfakk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 32565@debbugs.gnu.org

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:06:28 -0400
> Subject: [PATCH 1/2] gnu: Add python-falcon.
>
> * gnu/packages/python-web.scm (python-falcon): New variable.

[...]

> +    (home-page "https://falconframework.org")
> +    (synopsis
> +     "Unladen web framework for building APIs and app backends")
> +    (description
> +     "Falcon is a bare-metal Python web API framework for building
> +high-performance microservices, app backends, and higher-level framework=
s.")

If you could make it a bit less catchy and more concrete (giving example
of actual features), that would be great.  :-)

>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:33:17 -0400
> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>
> * gnu/packages/python-web.scm (python-falcon-cors): New variable.

[...]

> +    (home-page
> +     "https://github.com/lwcolton/falcon-cors")
> +    (synopsis "Falcon CORS middlware")
                                  ^^
Typo.

What about =E2=80=9CFalcon @dfn{cross-origin resource sharing} (CORS) libra=
ry=E2=80=9D?

> +    (description "This middleware provides CORS support for Falcon.")

Ditto here, and bonus points if you add a couple of sentences to explain
what it does concretely.  :-)

Last point: unless you need them, you can remove the =E2=80=9Cpython2-=E2=
=80=9D variants
since Python 2.x is reaching end-of-life.

OK to push with changes along these lines.

Thank you!

Ludo=E2=80=99.