From: Christopher Baines <mail@cbaines.net>
To: Alex Griffin <a@ajgrf.com>
Cc: 35346@debbugs.gnu.org
Subject: [bug#35346] [PATCH 2/2] gnu: Add pass-otp.
Date: Sun, 21 Apr 2019 22:30:45 +0100 [thread overview]
Message-ID: <87d0lfjbay.fsf@cbaines.net> (raw)
In-Reply-To: <427dea7c-7fd4-4214-9bdc-c344a070e81d@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
Alex Griffin <a@ajgrf.com> writes:
> * gnu/packages/password-utils.scm (pass-otp): New variable.
>
...
> +(define-public pass-otp
> + (package
> + (name "pass-otp")
> + (version "1.2.0")
...
> + (native-search-paths
> + (list (search-path-specification
> + (variable "PASSWORD_STORE_SYSTEM_EXTENSION_DIR")
> + (files '("lib/password-store/extensions")))))
Hi Alex,
These changes are looking good, one thing though, is that I think this
native-search-paths field should be defined for the password-store
package, as it's the one that uses the search path.
While it works having it defined for pass-otp, having it in the
password-store package will become relevant if there are more extensions
packaged for Guix, as then they'll be able to take advantage of this as
well.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2019-04-21 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 17:50 [bug#35346] [0/2] Add pass-otp Alex Griffin
2019-04-20 17:54 ` [bug#35346] [PATCH 1/2] gnu: password-store: Allow external packages to provide extensions Alex Griffin
2019-04-20 17:55 ` [bug#35346] [PATCH 2/2] gnu: Add pass-otp Alex Griffin
2019-04-21 21:30 ` Christopher Baines [this message]
2019-04-22 0:26 ` Alex Griffin
2019-04-22 9:36 ` bug#35346: " Christopher Baines
2019-04-20 19:59 ` [bug#35346] Add patch tag to #35346 Alex Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0lfjbay.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=35346@debbugs.gnu.org \
--cc=a@ajgrf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).