From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIK3D-0005zK-QF for guix-patches@gnu.org; Sun, 21 Apr 2019 17:31:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIK3C-0002ZD-St for guix-patches@gnu.org; Sun, 21 Apr 2019 17:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIK3C-0002Z5-OG for guix-patches@gnu.org; Sun, 21 Apr 2019 17:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIK3C-0007yP-Dh for guix-patches@gnu.org; Sun, 21 Apr 2019 17:31:02 -0400 Subject: [bug#35346] [PATCH 2/2] gnu: Add pass-otp. Resent-Message-ID: References: <81378750-7d26-44e0-ae44-7d38bc1ccfc6@www.fastmail.com> <427dea7c-7fd4-4214-9bdc-c344a070e81d@www.fastmail.com> From: Christopher Baines In-reply-to: <427dea7c-7fd4-4214-9bdc-c344a070e81d@www.fastmail.com> Date: Sun, 21 Apr 2019 22:30:45 +0100 Message-ID: <87d0lfjbay.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Griffin Cc: 35346@debbugs.gnu.org --=-=-= Content-Type: text/plain Alex Griffin writes: > * gnu/packages/password-utils.scm (pass-otp): New variable. > ... > +(define-public pass-otp > + (package > + (name "pass-otp") > + (version "1.2.0") ... > + (native-search-paths > + (list (search-path-specification > + (variable "PASSWORD_STORE_SYSTEM_EXTENSION_DIR") > + (files '("lib/password-store/extensions"))))) Hi Alex, These changes are looking good, one thing though, is that I think this native-search-paths field should be defined for the password-store package, as it's the one that uses the search path. While it works having it defined for pass-otp, having it in the password-store package will become relevant if there are more extensions packaged for Guix, as then they'll be able to take advantage of this as well. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAly84QZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcRLw/8DBUtfguBIQS7GyypFTWJ2YTbQu0j64Jr6djMuWNPItTmAvnZN5zQS0Om +eqrKU5aKd3/pq4Xa1UnBzu0aUrf56B5J320c4WGM+TXwIm3KPb6ysAJ9TWE8Hx1 8s06nDEx/GVIU8plqbyou8M+ibMfbJ9hfCkDlq4Rpih+g1eN6/yZ7tomqaH7T0Ti IeNtKoeHB3bfA4QKqNMDhLyGJCMgmvmv+F4hwNWl7EkS3klJKBwAmNIyMbVNewhD K73mDAE4/eno2/ztwx3T6TJt4ZQ6j4tSCYeqZUI4mGf8qTZg7zHko/srGGdcDSAR kDHGqCdrw4D/9tq14/3CnMYhZdQwnP7MYBpooJ/NTzRj+8/U5eXHrkeiqtHCPtz8 U3FE6/lM1FroH3hiNaSNJW0Q0RxvF0my0+Un4qnZfsxcM+pjsKFy77DGDeYvJWny ZLp/QDZ7mxXZ+Ewqssw8IXX92UsCNhVTHkk05Seu2H1+p5t2glqeSvj8O2nriuxk 9uY53W3O3ybEx6eQ/9FPnUfMroADagCdZnqQhkDy41GHH8zvz/nhCNfzvT0NfsvH 5/6C0OE9hK6IcmA5njGNswGirCST9wLOd1/D/8i5Ik8cuYwjS71WKdLsiZZ/nP8/ AAbC9dxAMTGdhYUIKYaxdZMHwIgvtXj+qW0vEf+0XgHmWLTzLf0= =/llV -----END PGP SIGNATURE----- --=-=-=--