unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: swedebugia <swedebugia@riseup.net>
Cc: 36406@debbugs.gnu.org
Subject: [bug#36406] [PATCH] gnu: Add bitcoin-abc.
Date: Wed, 03 Jul 2019 00:39:13 +0200	[thread overview]
Message-ID: <87d0is3vu6.fsf@gnu.org> (raw)
In-Reply-To: <7db680ab-ff53-9569-3835-dd28f4889b8e@riseup.net> (swedebugia@riseup.net's message of "Thu, 27 Jun 2019 22:11:52 +0200")

Hi swedebugia,

swedebugia <swedebugia@riseup.net> skribis:

>>From 1ce83b0ceabac0260f6a9dc43d4df1cc75236aa7 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Thu, 27 Jun 2019 22:06:33 +0200
> Subject: [PATCH] gnu: Add bitcoin-abc.
>
> * gnu/packages/finance.scm (bitcoin-abc): New variable.

[...]

> +(define-public bitcoin-abc
> +  ;; This is a fork of bitcoin-core and identical to upstream.
> +  (package
> +    (name "bitcoin-abc")

Since everything except ‘source’ is identical, I think we should write
it as:

  (package
    (inherit bitcoin-core)
    …)

> +    (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
> +    (description
> +     "Bitcoin Cash is a digital currency that enables instant payments to anyone
> +anywhere in the world.  It uses peer-to-peer technology to operate without
> +central authority: managing transactions and issuing money are carried out
> +collectively by the network.  Bitcoin ABC is the reference implementation
> +of the Bitcoin Cash protocol.  This package provides the Bitcoin Cash command
> +line client and a client based on Qt. This is a fork of bitcoin-core.")

Could you make the description a bit more specific to Bitcoin ABC?
Otherwise it’s hard to tell how it differs from bitcoin-core.

Thanks in advance!

Ludo’.

  reply	other threads:[~2019-07-02 22:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 20:11 [bug#36406] [PATCH] gnu: Add bitcoin-abc swedebugia
2019-07-02 22:39 ` Ludovic Courtès [this message]
2019-08-01 20:43   ` [bug#36406] [PATCHv2] " swedebugia
2019-08-22 15:41     ` bug#36406: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0is3vu6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=36406@debbugs.gnu.org \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).