From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34074)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRRU-0003vf-Me
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:40:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRRS-0003ti-Ox
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:40:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39301)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hiRRS-0003s1-4G
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRRR-0004ty-UT
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:40:01 -0400
Subject: [bug#36406] [PATCH] gnu: Add bitcoin-abc.
Resent-Message-ID: <handler.36406.B36406.156210716618793@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <7db680ab-ff53-9569-3835-dd28f4889b8e@riseup.net>
Date: Wed, 03 Jul 2019 00:39:13 +0200
In-Reply-To: <7db680ab-ff53-9569-3835-dd28f4889b8e@riseup.net>
 (swedebugia@riseup.net's message of "Thu, 27 Jun 2019 22:11:52 +0200")
Message-ID: <87d0is3vu6.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: swedebugia <swedebugia@riseup.net>
Cc: 36406@debbugs.gnu.org

Hi swedebugia,

swedebugia <swedebugia@riseup.net> skribis:

>>>From 1ce83b0ceabac0260f6a9dc43d4df1cc75236aa7 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Thu, 27 Jun 2019 22:06:33 +0200
> Subject: [PATCH] gnu: Add bitcoin-abc.
>
> * gnu/packages/finance.scm (bitcoin-abc): New variable.

[...]

> +(define-public bitcoin-abc
> +  ;; This is a fork of bitcoin-core and identical to upstream.
> +  (package
> +    (name "bitcoin-abc")

Since everything except =E2=80=98source=E2=80=99 is identical, I think we s=
hould write
it as:

  (package
    (inherit bitcoin-core)
    =E2=80=A6)

> +    (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash p=
rotocol")
> +    (description
> +     "Bitcoin Cash is a digital currency that enables instant payments t=
o anyone
> +anywhere in the world.  It uses peer-to-peer technology to operate witho=
ut
> +central authority: managing transactions and issuing money are carried o=
ut
> +collectively by the network.  Bitcoin ABC is the reference implementation
> +of the Bitcoin Cash protocol.  This package provides the Bitcoin Cash co=
mmand
> +line client and a client based on Qt. This is a fork of bitcoin-core.")

Could you make the description a bit more specific to Bitcoin ABC?
Otherwise it=E2=80=99s hard to tell how it differs from bitcoin-core.

Thanks in advance!

Ludo=E2=80=99.