unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: Pierre Neidhardt <mail@ambrevar.xyz>,
	dario <dario.klingenberg@web.de>,
	39804@debbugs.gnu.org
Subject: [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next)
Date: Mon, 02 Mar 2020 21:19:24 -0500	[thread overview]
Message-ID: <87d09ukwnn.fsf@gmail.com> (raw)
In-Reply-To: <b4cbb0be620be359281742d5c6ab10aeac8c5782.camel@student.tugraz.at> (Leo Prikler's message of "Fri, 28 Feb 2020 10:53:08 +0100")

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> Am Freitag, den 28.02.2020, 09:32 +0100 schrieb Pierre Neidhardt:
>> The `#:emacs` field tells the build system which Emacs package to use
>> to
>> build this package.  There may be something that not compatible
>> between
>> our current build system and emacs-next.
>> 
>> I've CC'ed Maxim and Leo, they might know more than me.
> This issue should be addressed by #39375, which is currently waiting to
> be pushed to master or staging.

If we don't hear back from
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39823 in a day or two, I'd
be OK with pushing #39375 to master.

> I took the liberty to rewrite this
> patch with that one in mind – the build succeeds now, but I'm not sure
> how to run it.  Perhaps I'm missing a few bits.
>
> Regards,
> Leo
>
> From 73eb9dac1bd13a8107aaedddecbe9bf7821a4841 Mon Sep 17 00:00:00 2001
> From: Leo Prikler <leo.prikler@student.tugraz.at>
> Date: Fri, 28 Feb 2020 10:46:23 +0100
> Subject: [PATCH 1/2] gnu: Add emacs-xelb-next.
>
> * gnu/packages/emacs-xyz.scm (emacs-xelb-next): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 76b9746f69..fa007f158b 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9661,6 +9661,14 @@ features an object-oriented API and permits a certain degree of concurrency.
>  It should enable you to implement low-level X11 applications.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-xelb-next
> +  (package
> +    (inherit emacs-xelb)
> +    (name "emacs-xelb-next")
> +    (arguments
> +     `(,@(package-arguments emacs-xelb)
> +       #:emacs ,emacs-next))))
> +
>  (define-public emacs-exwm
>    (package
>      (name "emacs-exwm")
> -- 
> 2.25.1
>
>
> From 19056fa969d830d5ee1065988f6a5b4f76fcbae9 Mon Sep 17 00:00:00 2001
> From: dakling <dario.klingenberg@web.de>
> Date: Wed, 26 Feb 2020 22:07:44 +0100
> Subject: [PATCH 2/2] gnu: Add emacs-exwm-next.
>
> * gnu/packages/emacs-xyz.scm (emacs-exwm-next): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index fa007f158b..9567324da8 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9739,6 +9739,24 @@ It should enable you to implement low-level X11 applications.")
>  built on top of XELB.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-exwm-next
> +  (package
> +    (inherit emacs-exwm)
> +    (name "emacs-exwm-next")
> +    (propagated-inputs
> +     `(("emacs-xelb" ,emacs-xelb-next)))
> +    (inputs
> +     `(("xhost" ,xhost)
> +       ("emacs-next" ,emacs-next)
> +       ("dbus" ,dbus)))
> +    (arguments
> +     `(,@(package-arguments emacs-exwm)
> +       #:emacs ,emacs-next))
> +    (home-page "https://github.com/ch11ng/exwm")
> +    (description "EXWM is a full-featured tiling X window manager for Emacs
> +built on top of XELB.")
> +    (license license:gpl3+)))

No need to repeat the home-page, description and license field.

Other than that, LGTM.

Maxim

  parent reply	other threads:[~2020-03-03  2:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 21:07 [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next) dakling
2020-02-27  9:53 ` Pierre Neidhardt
2020-02-27 22:04   ` dario
2020-02-28  8:32     ` Pierre Neidhardt
2020-02-28  9:53       ` Leo Prikler
2020-02-28 14:45         ` Maxim Cournoyer
2020-03-03  2:19         ` Maxim Cournoyer [this message]
2020-03-11  3:54           ` Maxim Cournoyer
2020-03-15 13:48             ` Leo Prikler
2020-03-17  1:59               ` Maxim Cournoyer
2020-03-23  1:52               ` Maxim Cournoyer
2020-03-23  8:57                 ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d09ukwnn.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=39804@debbugs.gnu.org \
    --cc=dario.klingenberg@web.de \
    --cc=leo.prikler@student.tugraz.at \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).