From: Pierre Neidhardt <mail@ambrevar.xyz>
To: dakling <dario.klingenberg@web.de>
Cc: 39804@debbugs.gnu.org
Subject: [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next)
Date: Thu, 27 Feb 2020 10:53:22 +0100 [thread overview]
Message-ID: <8736aw8igd.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87blplqcdd.fsf@web.de> (dakling's message of "Wed, 26 Feb 2020 22:07:44 +0100")
[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]
Thanks for your submission.
Note that you need not create a new thread for to send a update of a
patch. If you used the `git send-email` command, you could have used
the `--to=` option to send to the previous thread. For instance
--8<---------------cut here---------------start------------->8---
git send-email --to=39756@debbugs.gnu.org 0001-my-patch.diff
--8<---------------cut here---------------end--------------->8---
Comments below:
> ---
> gnu/packages/emacs-xyz.scm | 71 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 6b9027df8a..c6df469895 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8601,6 +8601,77 @@ It should enable you to implement low-level X11 applications.")
> built on top of XELB.")
> (license license:gpl3+)))
>
> +(define-public emacs-exwm-next
I think you don't need to copy the whole package definition. Instead,
you could `inherit' from the original definition and only adjust the
name, description, inputs and maybe arguments.
For instance
--8<---------------cut here---------------start------------->8---
(define-public emacs-exwm-next
(package
(inherit emacs)
(name "emacs-exwm-next")
(inputs ...)
(synopsys ...)))
--8<---------------cut here---------------end--------------->8---
See `substitute-keyword-arguments' in the fftwf package for a convenient
way to modify just one argument.
> + (package
> + (name "emacs-exwm-next")
> + (version "0.23")
> + (synopsis "Emacs X window manager")
Maybe tell that this is using the next version of Emacs.
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://elpa.gnu.org/packages/exwm-"
> + version ".tar"))
> + (sha256
> + (base32
> + "05w1v3wrp1lzz20zd9lcvr5nhk809kgy6svvkbs15xhnr6x55ad5"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-xelb" ,emacs-xelb)))
> + (inputs
> + `(("xhost" ,xhost)
> + ("emacs-next" ,emacs-next)
> + ("dbus" ,dbus)))
> + ;; The following functions and variables needed by emacs-exwm are
> + ;; not included in emacs-minimal:
> + ;; scroll-bar-mode, fringe-mode
> + ;; x-display-pixel-width, x-display-pixel-height
> + (arguments
> + `(#:emacs ,emacs
Shouldn't this be `emacs-next` as well?
Cheers!
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-27 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:07 [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next) dakling
2020-02-27 9:53 ` Pierre Neidhardt [this message]
2020-02-27 22:04 ` dario
2020-02-28 8:32 ` Pierre Neidhardt
2020-02-28 9:53 ` Leo Prikler
2020-02-28 14:45 ` Maxim Cournoyer
2020-03-03 2:19 ` Maxim Cournoyer
2020-03-11 3:54 ` Maxim Cournoyer
2020-03-15 13:48 ` Leo Prikler
2020-03-17 1:59 ` Maxim Cournoyer
2020-03-23 1:52 ` Maxim Cournoyer
2020-03-23 8:57 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736aw8igd.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=39804@debbugs.gnu.org \
--cc=dario.klingenberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).