From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 44567-done@debbugs.gnu.org
Subject: [bug#44567] [PATCH] publish: Improve HTTP performance when not using --cache.
Date: Mon, 16 Nov 2020 09:26:00 +0100 [thread overview]
Message-ID: <87d00d4siv.fsf@gnu.org> (raw)
In-Reply-To: <87mtzhdgvr.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Nov 2020 00:12:40 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> I didn't observe any meaningful difference, it perhaps felt more
> 'steady'. The value comes from what Linux, the kernel, configures as a
> max value by default (see 'man tcp' and 'cat
> /proc/sys/net/core/wmem_max').
I see, makes sense!
>>> (make-gzip-output-port (response-port response)
>>> #:level level
>>> - #:buffer-size (* 64 1024)))
>>> + #:buffer-size %default-buffer-size))
>>
>> Does the gzip buffer size have to match the TCP buffer size? I’d say
>> not necessarily, so perhaps we should have a separate variable for the
>> gzip buffer size (or keep it as is).
>
> It doesn't, but if we're going to pick some value, it seems the network
> one (SO_SNDBUF) should be the lowest common denominator. Since we're
> augmenting the previous value, I've just all made them agree.
OK.
>> That’s it, thank you!
>
> Thanks for the review! Pushed to the 1.2.0-version branch.
Great, thanks!
Ludo’.
prev parent reply other threads:[~2020-11-16 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 3:57 [bug#44567] [PATCH] publish: Improve HTTP performance when not using --cache Maxim Cournoyer
2020-11-13 17:19 ` Ludovic Courtès
2020-11-16 5:12 ` bug#44567: " Maxim Cournoyer
2020-11-16 8:26 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d00d4siv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44567-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).