From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QAGrDuE3sl9pYAAA0tVLHw (envelope-from ) for ; Mon, 16 Nov 2020 08:27:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6DjKCuE3sl9MfQAAB5/wlQ (envelope-from ) for ; Mon, 16 Nov 2020 08:27:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94563940538 for ; Mon, 16 Nov 2020 08:27:12 +0000 (UTC) Received: from localhost ([::1]:40616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keZqv-0003US-7r for larch@yhetil.org; Mon, 16 Nov 2020 03:27:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keZqo-0003SZ-MX for guix-patches@gnu.org; Mon, 16 Nov 2020 03:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keZqo-0000uS-Cw for guix-patches@gnu.org; Mon, 16 Nov 2020 03:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keZqo-000081-96 for guix-patches@gnu.org; Mon, 16 Nov 2020 03:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44567] [PATCH] publish: Improve HTTP performance when not using --cache. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Nov 2020 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44567 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 44567-done@debbugs.gnu.org Received: via spool by 44567-done@debbugs.gnu.org id=D44567.1605515170426 (code D ref 44567); Mon, 16 Nov 2020 08:27:02 +0000 Received: (at 44567-done) by debbugs.gnu.org; 16 Nov 2020 08:26:10 +0000 Received: from localhost ([127.0.0.1]:55009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keZpy-00006n-Bl for submit@debbugs.gnu.org; Mon, 16 Nov 2020 03:26:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keZpw-00006W-HS for 44567-done@debbugs.gnu.org; Mon, 16 Nov 2020 03:26:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58438) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keZpr-0000aW-9j; Mon, 16 Nov 2020 03:26:03 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47030 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keZpp-0008HB-AL; Mon, 16 Nov 2020 03:26:02 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201111035727.11184-1-maxim.cournoyer@gmail.com> <87361dcgzc.fsf@gnu.org> <87mtzhdgvr.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 16 Nov 2020 09:26:00 +0100 In-Reply-To: <87mtzhdgvr.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Nov 2020 00:12:40 -0500") Message-ID: <87d00d4siv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: VlmWMPBho41K Hi, Maxim Cournoyer skribis: > I didn't observe any meaningful difference, it perhaps felt more > 'steady'. The value comes from what Linux, the kernel, configures as a > max value by default (see 'man tcp' and 'cat > /proc/sys/net/core/wmem_max'). I see, makes sense! >>> (make-gzip-output-port (response-port response) >>> #:level level >>> - #:buffer-size (* 64 1024))) >>> + #:buffer-size %default-buffer-size)) >> >> Does the gzip buffer size have to match the TCP buffer size? I=E2=80=99= d say >> not necessarily, so perhaps we should have a separate variable for the >> gzip buffer size (or keep it as is). > > It doesn't, but if we're going to pick some value, it seems the network > one (SO_SNDBUF) should be the lowest common denominator. Since we're > augmenting the previous value, I've just all made them agree. OK. >> That=E2=80=99s it, thank you! > > Thanks for the review! Pushed to the 1.2.0-version branch. Great, thanks! Ludo=E2=80=99.