unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Eric Brown <ecbrown@ericcbrown.com>, 40764-done@debbugs.gnu.org
Subject: [bug#40764] New package: r-restrserve
Date: Mon, 14 Dec 2020 12:54:57 +0300	[thread overview]
Message-ID: <87czzcvhji.fsf@gmail.com> (raw)
In-Reply-To: <86sg8dhh5x.fsf@gmail.com> (zimoun's message of "Thu, 10 Dec 2020 15:25:30 +0100")

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

Hello,

zimoun <zimon.toutoune@gmail.com> writes:

[…]

> The option “format-patch --base” reduces the burden and I proposed this
> patch:
>
>    <http://issues.guix.gnu.org/issue/43946>
>
> Adding directly in the patch the (base) commit where the patch is known
> to apply fixes most of the issues.  IMO.

It adds ‘base-commit’ and optionally ‘prerequisite-patch-id’ (see [1]), which will
help you to checkout base-commit and apply a patch, but still you will
need to rebase on origin/master with solving conflicts AFAIK.

Also, on git version 2.29.2 --base requires an argument.  If we apply
the patch on 43946 issue, we should mention this in example.  

And, IMHO, the --base flag should be mention inside the first paragraph
of [2], where format-patch is recommended for patch submission.
Otherwise people will send with and without --base, which probably
will not hurt, but still.

[1]: --base=HEAD~~ output example
--8<---------------cut here---------------start------------->8---
oleg@guixsd ~/src/guix-master$ git format-patch --base=HEAD~~ --stdout HEAD~..HEAD
From ea50795d7f54582d5c439f60e836ff2ee5d8aed2 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Sat, 12 Dec 2020 00:39:26 -0500
Subject: [PATCH] gnu: linux-libre 4.4: Update to 4.4.248.

* gnu/packages/linux.scm (linux-libre-4.4-version): Update to 4.4.248.
(linux-libre-4.4-pristine-source): Update hash.
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4c5917bc59..73dec7d1b7 100644
[…]


base-commit: 4c327e025277dd59b864200d5ecf671b5656e7c9
prerequisite-patch-id: 2f8bef97c220d126e922b526c4fccc847592311d
-- 
2.29.2

--8<---------------cut here---------------end--------------->8---

[2] https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2020-12-14 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 11:12 [bug#40764] New package: r-restrserve Eric Brown
2020-05-30 17:56 ` Marius Bakke
2020-12-09 19:36 ` bug#40764: " Christopher Baines
2020-12-10 12:36   ` [bug#40764] " zimoun
2020-12-10 13:18     ` Ricardo Wurmus
2020-12-10 14:22       ` Efraim Flashner
2020-12-10 14:25       ` zimoun
2020-12-14  9:54         ` Oleg Pykhalov [this message]
2020-12-15 14:35           ` zimoun
2021-05-26 22:33 ` [bug#48690] " Eric Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czzcvhji.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=40764-done@debbugs.gnu.org \
    --cc=ecbrown@ericcbrown.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).