unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>,
	Eric Brown <ecbrown@ericcbrown.com>
Cc: 40764-done@debbugs.gnu.org
Subject: [bug#40764] New package: r-restrserve
Date: Thu, 10 Dec 2020 13:36:34 +0100	[thread overview]
Message-ID: <864kktj0rx.fsf@gmail.com> (raw)
In-Reply-To: <87mtym4vri.fsf@cbaines.net>

Hi Chris,

On Wed, 09 Dec 2020 at 19:36, Christopher Baines <mail@cbaines.net> wrote:

> In the future, I'd strongly recommend not adding packages to the bottom
> of modules, unless you really want the package definition to be
> there. If every new definition gets added at the bottom, merge conflicts
> become very likely. Related to this, I also moved the package definition
> up off the bottom of the module.

What do you mean?  From my understanding, we always add new R packages
at the botton of the files cran.scm or bioconductor.scm; mainly.

Instead, what do you suggest?  Again, from my understanding, merge
conflicts could happen wherever the package is added.  If the package is
added at one location in the file and this location does not make sense
anymore because other packages had been added before this location, then
conflict.  For sure, adding bottom increases the probability it
happens. ;-) But adding elsewhere does not prevent neither.

The only fix to avoid boring conflicts is to reduce the time between the
submission and the merge, IMHO.

Do I miss something?

All the best,
simon




  reply	other threads:[~2020-12-10 13:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 11:12 [bug#40764] New package: r-restrserve Eric Brown
2020-05-30 17:56 ` Marius Bakke
2020-12-09 19:36 ` bug#40764: " Christopher Baines
2020-12-10 12:36   ` zimoun [this message]
2020-12-10 13:18     ` [bug#40764] " Ricardo Wurmus
2020-12-10 14:22       ` Efraim Flashner
2020-12-10 14:25       ` zimoun
2020-12-14  9:54         ` Oleg Pykhalov
2020-12-15 14:35           ` zimoun
2021-05-26 22:33 ` [bug#48690] " Eric Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864kktj0rx.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=40764-done@debbugs.gnu.org \
    --cc=ecbrown@ericcbrown.com \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).