* [bug#52188] [PATCH] [core-updates-frozen] Fix gnome-builder.
@ 2021-11-29 23:19 Vivien Kraus via Guix-patches via
2021-12-01 9:09 ` bug#52188: " Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2021-11-29 23:19 UTC (permalink / raw)
To: 52188
[-- Attachment #1.1: Type: text/plain, Size: 202 bytes --]
Dear guix,
GNOME builder is not ready yet for libsoup 3, so I suggest that we add a
libsoup 2 variant for devhelp, and use libsoup 2 everywhere for
builder. What do you think?
Best regards,
Vivien
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Add a libsoup 2 variant for devhelp --]
[-- Type: text/x-patch, Size: 1395 bytes --]
From 3d579f6a778f92db432b9de4065295cd510f712d Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 30 Nov 2021 00:03:07 +0100
Subject: [PATCH 1/2] gnu: devhelp: Add a libsoup 2 variant.
* gnu/packages/gnome.scm (devhelp-with-libsoup2): New variable.
---
gnu/packages/gnome.scm | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 8e0e750180..ccb99ca8ec 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5854,6 +5854,22 @@ (define-public devhelp
throughout GNOME for API documentation).")
(license license:gpl2+)))
+(define-public devhelp-with-libsoup2
+ (package/inherit devhelp
+ (arguments
+ (substitute-keyword-arguments (package-arguments devhelp)
+ ((#:phases phases '%standard-phases)
+ `(modify-phases %standard-phases
+ (add-after 'unpack 'skip-gtk-update-icon-cache
+ ;; Don't create 'icon-theme.cache'.
+ (lambda _
+ (substitute* "build-aux/meson/meson_post_install.py"
+ (("gtk-update-icon-cache") "true"))))))))
+ (inputs
+ `(("amtk" ,amtk)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("webkitgtk" ,webkitgtk-with-libsoup2)))))
+
(define-public cogl
(package
(name "cogl")
--
2.34.0
[-- Attachment #1.3: Use libsoup 2 in GNOME builder --]
[-- Type: text/x-patch, Size: 1952 bytes --]
From 6c896768d191f1fbc129b2c5b1d7bcd8a88aa93c Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 30 Nov 2021 00:05:18 +0100
Subject: [PATCH 2/2] gnu: gnome-builder: Use libsoup 2.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* gnu/packages/gnome.scm (gnome-builder) [phase 'patch-meson]: Don’t search
for webkit2gtk-4.1.
[inputs]: Replace devhelp with devhelp-with-libsoup2 and
webkit with webkit-with-libsoup2.
---
gnu/packages/gnome.scm | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ccb99ca8ec..5f99616571 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12486,10 +12486,7 @@ (define-public gnome-builder
(substitute* "src/libide/meson.build"
(("/usr/lib")
(string-append (assoc-ref inputs "python-pygobject")
- "/lib")))
- (substitute* "meson.build"
- (("webkit2gtk-4.0") "webkit2gtk-4.1"))
- #t))
+ "/lib")))))
(add-after 'configure 'fix-ninja
(lambda _
;; #43296: meson(?) incorrectly assumes we want to link
@@ -12505,7 +12502,7 @@ (define-public gnome-builder
(inputs
`(("cmark" ,cmark)
("clang" ,clang)
- ("devhelp" ,devhelp)
+ ("devhelp" ,devhelp-with-libsoup2)
("glade" ,glade3)
("gspell" ,gspell)
("gtk+" ,gtk+)
@@ -12521,7 +12518,7 @@ (define-public gnome-builder
("sysprof" ,sysprof)
("template-glib" ,template-glib)
("vte" ,vte)
- ("webkitgtk" ,webkitgtk)))
+ ("webkitgtk" ,webkitgtk-with-libsoup2)))
(propagated-inputs
`(("gtksourceview" ,gtksourceview))) ;needed for settings
(native-inputs
--
2.34.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#52188: [PATCH] [core-updates-frozen] Fix gnome-builder.
2021-11-29 23:19 [bug#52188] [PATCH] [core-updates-frozen] Fix gnome-builder Vivien Kraus via Guix-patches via
@ 2021-12-01 9:09 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2021-12-01 9:09 UTC (permalink / raw)
To: Vivien Kraus; +Cc: 52188-done
Hello Vivien,
> GNOME builder is not ready yet for libsoup 3, so I suggest that we add a
> libsoup 2 variant for devhelp, and use libsoup 2 everywhere for
> builder. What do you think?
Seems fair, pushed both patches to c-u-f. I noticed the following
warnings at Gnome-Builder start:
--8<---------------cut here---------------start------------->8---
10:07:16.8272 ide-application-plugins[ 19073]: CRITICAL: Cannot enable Python 3 plugins: Typelib file for namespace 'GtkSource', version '4' not found
10:07:16.8319 libpeas[ 19073]: WARNING: The 'python3' plugin loader has not been enabled
10:07:16.8320 libpeas[ 19073]: WARNING: The 'python3' plugin loader has not been enabled
--8<---------------cut here---------------end--------------->8---
Something we would like to fix?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-01 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 23:19 [bug#52188] [PATCH] [core-updates-frozen] Fix gnome-builder Vivien Kraus via Guix-patches via
2021-12-01 9:09 ` bug#52188: " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).