unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kyle Andrews <kyle@posteo.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55381@debbugs.gnu.org
Subject: [bug#55381] [PATCH 05/14] gnu: Add r-unglue.
Date: Sun, 15 May 2022 16:38:44 +0000	[thread overview]
Message-ID: <87czge67sd.fsf@posteo.net> (raw)
In-Reply-To: <464037be8d677efd5402d66a0c59db221cb960a6.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 2048 bytes --]


Hi Maxime,

Maxime Devos <maximedevos@telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> kyle schreef op do 12-05-2022 om 02:10 [+0000]:
>> Use syntax inspired by the package 'glue'
>
> Shouldn't this be 'r-glue'?  Guix doesn't have a package named 'glue'.
> Also, writing a description (+- = some factual statements) in the
> imperative mood ... is technically possible, but I wouldn't recommend
> it.  Referring to another package for more information on what 'rust-
> unglue' is about is technically possible, but a bit cumbersome for the
> reader I think.  Maybe you can re-use parts of the description of
> 'r-glue'.
>

This (and r-glue too) is an R package designed to be installed and used
from within R. I noticed that the Pandas python package, for example,
doesn't refer to itself as python-pandas in its Guix documentation.
There are numerous other instances in Guix where such library software
for high-level languages refer to themselves and other related packages
as within their own ecosystems instead of the Guix ecosystem. However,
in this particular case I included in parenthesis "(provided by r-glue
in Guix)".

>>  to extract matched substrings in a
>> +more intuitive and compact way than by using standard regular expressions.
>
> This is a bit markety language.
>
> More generally, upstream descriptions often aren't great and require
> some tweaking, expanding (and sometimes abbreviation, though not in
> this particular case).  The manual has some general guidelines in
> (guix)Synopses and Descriptions.

Thanks, I had a look.

> FWIW, I consider 'emacs', 'hello' and 'sed' to have good descriptions,
> though the emacs description goes a bit markety with ‘highly
> customizable ... extensive documention on everything’ and such ...
> though in the case of Emacs those claims appear to be actually true so
> maybe it's a good description after all.
>

I made a few small tweaks which I feel significantly reduces the
"marketing" aspect. See the included patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: r-unglue updated patch --]
[-- Type: text/x-patch, Size: 1371 bytes --]

From 9a30410e850000e839002649a5f6183f174fdfa2 Mon Sep 17 00:00:00 2001
Message-Id: <9a30410e850000e839002649a5f6183f174fdfa2.1652634138.git.kyle@posteo.net>
From: Kyle Andrews <kyle@posteo.net>
Date: Sun, 15 May 2022 13:01:30 -0400
Subject: [PATCH] gnu: Add r-unglue.

---
 gnu/packages/cran.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 5c05f20ea7..bbe18e1d67 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -33255,3 +33255,23 @@ (define-public r-zoeppritz
 coefficients or scattering amplitudes, for seismological P and S-waves at an
 interface.")
     (license license:gpl2+)))
+
+(define-public r-unglue
+  (package
+   (name "r-unglue")
+   (version "0.1.0")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (cran-uri "unglue" version))
+     (sha256
+      (base32 "0w8ld4xllx0lj1jz8i2sj92f8136hlwri1d8ldpg1ymxj7aw93vg"))))
+   (properties `((upstream-name . "unglue")))
+   (build-system r-build-system)
+   (home-page "https://cran.r-project.org/package=unglue")
+   (synopsis "Extract Matched Substrings Using a Pattern")
+   (description
+    "Use syntax inspired by the package 'glue' (provided by r-glue in
+Guix) to extract matched substrings in a more compact way than by
+using regular expressions.")
+   (license license:gpl3)))
-- 
2.36.0


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


Cheers,
Kyle





  reply	other threads:[~2022-05-15 17:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  2:10 [bug#55379] [PATCH 01/14] gnu: Add r-gpg kyle
2022-05-12  2:10 ` [bug#55380] [PATCH 02/14] gnu: Add r-piton kyle
2022-12-29 19:47   ` bug#55380: " Ricardo Wurmus
2022-05-12  2:10 ` [bug#55379] [PATCH 03/14] gnu: Add r-tidyxl kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 04/14] gnu: Add r-unpivotr kyle
2022-05-14 10:53   ` Maxime Devos
2022-05-18  1:09     ` Kyle Andrews
2022-05-12  2:10 ` [bug#55381] [PATCH 05/14] gnu: Add r-unglue kyle
2022-05-14 18:18   ` Maxime Devos
2022-05-15 16:38     ` Kyle Andrews [this message]
2022-12-29 19:56   ` bug#55381: " Ricardo Wurmus
2022-05-12  2:10 ` [bug#55379] [PATCH 06/14] gnu: Add r-vcdextra kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 07/14] gnu: Add r-ca kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 08/14] gnu: Add r-qvcalc kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 09/14] gnu: Add r-gnm kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 10/14] gnu: Add r-relimp kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 11/14] gnu: Add r-picosat kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 12/14] gnu: Add r-ryacas kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 13/14] gnu: Add r-showimage kyle
2022-05-12  2:10 ` [bug#55379] [PATCH 14/14] gnu: Add r-genoud kyle
2022-05-13  7:10 ` [bug#55379] [PATCH 01/14] gnu: Add r-gpg Maxime Devos
     [not found]   ` <87bkw0jb3i.fsf@posteo.net>
2022-05-14 18:02     ` Maxime Devos
2022-05-15 16:24       ` Kyle Andrews
2022-05-14 18:07     ` Maxime Devos
2022-12-18  8:58 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czge67sd.fsf@posteo.net \
    --to=kyle@posteo.net \
    --cc=55381@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).