From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart <jgart@dismail.de>
Cc: 53039-done@debbugs.gnu.org
Subject: bug#53039: [PATCH] build-system/python: Change let* to let.
Date: Wed, 18 May 2022 09:06:58 -0400 [thread overview]
Message-ID: <87czgb0z2l.fsf@gmail.com> (raw)
In-Reply-To: <20220105224600.9227-1-jgart@dismail.de> (jgart@dismail.de's message of "Wed, 5 Jan 2022 17:46:00 -0500")
Hi,
jgart <jgart@dismail.de> writes:
> * guix/build/python-build-system.scm (site-packages): Change let* to let for
> readability and since let* is unused.
> ---
> guix/build/python-build-system.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 08871f60cd..a9b1c74f63 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -11,6 +11,7 @@
> ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
> ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> +;;; Copyright © 2022 jgart <jgart@dismail.de>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -176,8 +177,8 @@ (define (python-output outputs)
>
> (define (site-packages inputs outputs)
> "Return the path of the current output's Python site-package."
> - (let* ((out (python-output outputs))
> - (python (assoc-ref inputs "python")))
> + (let ((out (python-output outputs))
> + (python (assoc-ref inputs "python")))
> (string-append out "/lib/python" (python-version python) "/site-packages")))
>
> (define (add-installed-pythonpath inputs outputs)
As Maxime mentioned, that should go to core-updates. It's nice to use
the --subject-prefix option of 'git format-patch' to change it to
"[PATCH core-updates]", so that we don't apply these mistakenly to
master and cause world rebuilds :-)
Another note; only changes of minimally 10 lines are copyrightable, so
you do not need to add a copyright attribution for trivial changes such
as this one.
I've made the change to core-updates and committed as 47fac5dc59; closing.
Thank you!
Maxim
next prev parent reply other threads:[~2022-05-18 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 22:46 [bug#53039] [PATCH] build-system/python: Change let* to let jgart via Guix-patches via
2022-01-09 21:03 ` Maxime Devos
2022-05-18 13:06 ` Maxim Cournoyer [this message]
2022-05-19 4:50 ` jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czgb0z2l.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=53039-done@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).