From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6BezLsXvhGKaRwEAbAwnHQ (envelope-from ) for ; Wed, 18 May 2022 15:08:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EFOvLsXvhGJkjwAA9RJhRA (envelope-from ) for ; Wed, 18 May 2022 15:08:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32D79347C2 for ; Wed, 18 May 2022 15:08:21 +0200 (CEST) Received: from localhost ([::1]:41382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrJPY-0002ca-9h for larch@yhetil.org; Wed, 18 May 2022 09:08:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrJPG-0002Zp-Np for guix-patches@gnu.org; Wed, 18 May 2022 09:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrJPG-0006k6-AN for guix-patches@gnu.org; Wed, 18 May 2022 09:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrJPG-0001UJ-4V for guix-patches@gnu.org; Wed, 18 May 2022 09:08:02 -0400 Subject: bug#53039: [PATCH] build-system/python: Change let* to let. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 18 May 2022 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53039 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 53039-done@debbugs.gnu.org Mail-Followup-To: 53039@debbugs.gnu.org, maxim.cournoyer@gmail.com, jgart@dismail.de Received: via spool by 53039-done@debbugs.gnu.org id=D53039.16528792435671 (code D ref 53039); Wed, 18 May 2022 13:08:01 +0000 Received: (at 53039-done) by debbugs.gnu.org; 18 May 2022 13:07:23 +0000 Received: from localhost ([127.0.0.1]:59368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrJOc-0001TO-Ce for submit@debbugs.gnu.org; Wed, 18 May 2022 09:07:23 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:42778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrJOM-0001Sb-K3 for 53039-done@debbugs.gnu.org; Wed, 18 May 2022 09:07:21 -0400 Received: by mail-qk1-f171.google.com with SMTP id j6so1355973qkp.9 for <53039-done@debbugs.gnu.org>; Wed, 18 May 2022 06:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oUA/uib+3p/rFe874kzNASkSFE7lk1E796BEqyyUqAM=; b=ltEeBOFVlnmG1fgv0hdDBgq0VsMENasa87jvTs7xGa5uv0+TrojT+BwjhV64Jbyc8v 4aa1i8Jo65PegR8gMOd/0v2gv4SXR+98YjnS9GRb23nu5hhWj0g1vaTZmszPjoefrfzG m61gEq7Vs1GmY+mKBL0eLpDBSajZPTyU8z0Yz3GfqVyLa9PU1Zydh2AahLxwKoY+HeAp NO0PAnYKmGDqBtW9fQHI6w7MSK8t0rNs/ldZQqVkpyONdAm2vBT1HV8+3T/OX6VFZG1x xuq6l8O1blUrBl6wOVDD1XbW8l5RSlryS7jOFhWGvw2Psj/AvY20v2na3f8TnU0j/6oQ tjvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oUA/uib+3p/rFe874kzNASkSFE7lk1E796BEqyyUqAM=; b=Gkcy4x34fpd8jDFAx2NcDzY+6Bxy2FV+emArP/F/ssFTDkVfF5L0q/PRU/gmcmi+bh hQBcDGEDS7trVwJjHMWhTLKMYpYPb2NilXuBcjsPVp7rL0g9NDjeBt3oTOii867Ceyq6 n/IxTjpJT/zR3eqEW6cZFhmAxOWuJ7BxPg6yqqCmp2Uw2paUSzgZRg8TRkaT18uDw7qj FDxAscF7MXANXeHK7PZosQf8eft4a9a2HlHXbSgn8PWUgGw6iyOr0/7vSJnOboETTpkM OaDJ5ayjMmfFpyalD8V+MIIAq0HJ3fZs8CqhXF13UI8d+q/gVypD12lY61uIu/SJ19+K rxGg== X-Gm-Message-State: AOAM531jNiwzrQJN1SbwOqcS6JyjdBQGgbllNvduUzA0wNh+k7o9mtUk tQ16379XFROeJrAh7h+ikKjjplaFu54jlV0Q X-Google-Smtp-Source: ABdhPJxt8pD+22AMLXE6YBRX9Z8eV2R8x/7/eDuDmcEFAEnP8TBiC0cbuKNCCzU+/LC3H7s8SzRBrQ== X-Received: by 2002:a05:620a:400f:b0:6a0:5a16:69f3 with SMTP id h15-20020a05620a400f00b006a05a1669f3mr20050006qko.103.1652879220678; Wed, 18 May 2022 06:07:00 -0700 (PDT) Received: from hurd (dsl-205-233-124-104.b2b2c.ca. [205.233.124.104]) by smtp.gmail.com with ESMTPSA id x12-20020ac85f0c000000b002f39b99f6bdsm1292395qta.87.2022.05.18.06.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:07:00 -0700 (PDT) From: Maxim Cournoyer References: <20220105224600.9227-1-jgart@dismail.de> Date: Wed, 18 May 2022 09:06:58 -0400 In-Reply-To: <20220105224600.9227-1-jgart@dismail.de> (jgart@dismail.de's message of "Wed, 5 Jan 2022 17:46:00 -0500") Message-ID: <87czgb0z2l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652879301; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oUA/uib+3p/rFe874kzNASkSFE7lk1E796BEqyyUqAM=; b=M7p5NdKAxg4Gv1/r+CARW4rDK554iRdhX+HbfEteA9ZRSkQNCZJw/y9I5hhsV3iz5uAq4U jiQ4hlsAnZB6Yt8ujYnxqHe//LPy5ttsmWEzJ9fWPuKmg/V8bLbdJ/heaOAoQC4vyxBs2c 8wSrjM37qmKireY2fpsrh6awcMa4GIeSOIMh/h2wF+PWi2UwurA7FpE3Aim2QYopP9qpuE rPYzDXhZxwSfPOs2KlB+uOaWVbPiBxYWwZWfWRl0ULZwh6kb+tF87l+YZZ3SwWE9irKMAk e6MOzFEMCNndIvlTV3NlsuYxWaTJDv3lB5A197nACnWwbqTsi/pQ+00rczxPRQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652879301; a=rsa-sha256; cv=none; b=NbPR/bgCL+HHgZtCMZZUfN84JBW+i1X+6jWEIPDRvIqHr9MDmFpoNwg8aOpx5tq/Hz+Cfv L8hT1Nvq/GEWBgLber81k2kHLnrOaAHrnZD0hhYSnFNkZSOj+krSuRJl3LcRBLSWMBStCl +q+E5qOgVi+rl+MeefgGEezTCCE5DJ3EXtXwfZAazCTY+HSRxpkGk/RPCznQJ3Fw2j4nGX DFKmg0m3CIWq2ux6Bdzing6JK4qvw3YjDcmepr9Uspe/2zQpDXBBcJ6pealRAOZzGNN6Uh aQKuLXYmXYNQejwdKIPO0hrcmlWA9AIv90NYr0iipdgHnMWehNcMBo8gt5ABpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ltEeBOFV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ltEeBOFV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 32D79347C2 X-Spam-Score: 5.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: AjXMk14dJlSC Hi, jgart writes: > * guix/build/python-build-system.scm (site-packages): Change let* to let = for > readability and since let* is unused. > --- > guix/build/python-build-system.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/guix/build/python-build-system.scm b/guix/build/python-build= -system.scm > index 08871f60cd..a9b1c74f63 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -11,6 +11,7 @@ > ;;; Copyright =C2=A9 2020 Efraim Flashner > ;;; Copyright =C2=A9 2021 Lars-Dominik Braun > ;;; Copyright =C2=A9 2021 Maxime Devos > +;;; Copyright =C2=A9 2022 jgart > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -176,8 +177,8 @@ (define (python-output outputs) >=20=20 > (define (site-packages inputs outputs) > "Return the path of the current output's Python site-package." > - (let* ((out (python-output outputs)) > - (python (assoc-ref inputs "python"))) > + (let ((out (python-output outputs)) > + (python (assoc-ref inputs "python"))) > (string-append out "/lib/python" (python-version python) "/site-pack= ages"))) >=20=20 > (define (add-installed-pythonpath inputs outputs) As Maxime mentioned, that should go to core-updates. It's nice to use the --subject-prefix option of 'git format-patch' to change it to "[PATCH core-updates]", so that we don't apply these mistakenly to master and cause world rebuilds :-) Another note; only changes of minimally 10 lines are copyrightable, so you do not need to add a copyright attribution for trivial changes such as this one. I've made the change to core-updates and committed as 47fac5dc59; closing. Thank you! Maxim