* [bug#60567] [PATCH] gnu: Add ftxui
@ 2023-01-05 5:42 Artyom V. Poptsov
2023-01-08 17:06 ` Mathieu Othacehe
0 siblings, 1 reply; 7+ messages in thread
From: Artyom V. Poptsov @ 2023-01-05 5:42 UTC (permalink / raw)
To: 60567
[-- Attachment #1.1: Type: text/plain, Size: 91 bytes --]
Hello,
this patch adds FXTUI[1], a simple C++ library for terminal based user
interfaces.
[-- Attachment #1.2: 0001-gnu-Add-ftxui.patch --]
[-- Type: text/x-diff, Size: 3432 bytes --]
From 3453ac53e0d1bfe28e5536a89411584fc2461e29 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Thu, 5 Jan 2023 08:03:15 +0300
Subject: [PATCH] gnu: Add ftxui
* gnu/packages/tui.scm: New module.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add "tui.scm".
---
gnu/local.mk | 1 +
gnu/packages/tui.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 63 insertions(+)
create mode 100644 gnu/packages/tui.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index bc0309ee87..c110b54bef 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -605,6 +605,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/tmux.scm \
%D%/packages/toolkits.scm \
%D%/packages/tor.scm \
+ %D%/packages/tui.scm \
%D%/packages/tv.scm \
%D%/packages/uglifyjs.scm \
%D%/packages/uml.scm \
diff --git a/gnu/packages/tui.scm b/gnu/packages/tui.scm
new file mode 100644
index 0000000000..7a3037073b
--- /dev/null
+++ b/gnu/packages/tui.scm
@@ -0,0 +1,62 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2023 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages tui)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix utils)
+ #:use-module (guix gexp)
+ #:use-module (guix download)
+ #:use-module (guix git-download)
+ #:use-module (guix packages)
+ #:use-module (guix build-system cmake)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages version-control))
+
+(define-public ftxui
+ (package
+ (name "ftxui")
+ (version "3.0.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ArthurSonzogni/FTXUI")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32
+ "10a4yw2h29kixxyhll6cvrwyscsvz9asxry857a9l8nqvbhs946s"))
+ (file-name (git-file-name name version))))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f)) ;Tests require gtest
+ (home-page "https://github.com/ArthurSonzogni/FTXUI")
+ (synopsis "C++ Functional Terminal User Interface")
+ (description
+ "Functional Terminal (X) User interface (FTXUI) is a simple C++ library for
+terminal based user interfaces.
+
+Main features:
+@itemize
+@item Functional style.
+@item Keyboard & mouse navigation.
+@item Support for UTF8 and fullwidth chars.
+@item Support for animations.
+@item Support for drawing.
+@item No dependencies.
+@end itemize")
+ (license license:expat)))
--
2.34.1
[-- Attachment #1.3: Type: text/plain, Size: 966 bytes --]
I decided to place this package in a separate module called "tui.scm" as
there are other libraries for building text-based user interfaces that
can be added in the future (like [2], for example.)
Also to check if the library installed right I tried to build "tiles"
game[3] that is using FXTUI:
--8<---------------cut here---------------start------------->8---
git clone https://github.com/tusharpm/tiles.git
cd tiles
guix shell binutils gcc
mkdir build
cd build
cmake ..
make -j$(nproc)
--8<---------------cut here---------------end--------------->8---
Which worked out flawlessly.
Thanks,
- avp
References:
1. https://github.com/ArthurSonzogni/FTXUI
2. https://github.com/gansm/finalcut
3. https://github.com/tusharpm/tiles
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#60567] [PATCH] gnu: Add ftxui
2023-01-05 5:42 [bug#60567] [PATCH] gnu: Add ftxui Artyom V. Poptsov
@ 2023-01-08 17:06 ` Mathieu Othacehe
2023-01-08 17:49 ` Artyom V. Poptsov
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mathieu Othacehe @ 2023-01-08 17:06 UTC (permalink / raw)
To: Artyom V. Poptsov; +Cc: 60567
Hello Artyom,
> +++ b/gnu/packages/tui.scm
I'm not sure about the new tui module because a lot of packages could
fall into that category, all ncurses based programs for instance.
> + (arguments
> + (list #:tests? #f)) ;Tests require gtest
Providing googletest as a native-inputs doesn't help here?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#60567] [PATCH] gnu: Add ftxui
2023-01-08 17:06 ` Mathieu Othacehe
@ 2023-01-08 17:49 ` Artyom V. Poptsov
2023-01-08 17:52 ` Artyom V. Poptsov
2023-01-09 19:55 ` Artyom V. Poptsov
2 siblings, 0 replies; 7+ messages in thread
From: Artyom V. Poptsov @ 2023-01-08 17:49 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 60567
[-- Attachment #1.1: Type: text/plain, Size: 110 bytes --]
Hello Mathieu!
Thank you for the patch review.
I fixed the patch, please find the updated version attached.
[-- Attachment #1.2: 0001-gnu-Add-ftxui.patch --]
[-- Type: text/x-diff, Size: 4272 bytes --]
From a996eaee955cd933ef963d397b745421d6c4f402 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Thu, 5 Jan 2023 08:03:15 +0300
Subject: [PATCH] gnu: Add ftxui.
* gnu/packages/tui.scm: New module.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add "tui.scm".
---
gnu/local.mk | 1 +
gnu/packages/tui.scm | 79 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 80 insertions(+)
create mode 100644 gnu/packages/tui.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index bc0309ee87..c110b54bef 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -605,6 +605,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/tmux.scm \
%D%/packages/toolkits.scm \
%D%/packages/tor.scm \
+ %D%/packages/tui.scm \
%D%/packages/tv.scm \
%D%/packages/uglifyjs.scm \
%D%/packages/uml.scm \
diff --git a/gnu/packages/tui.scm b/gnu/packages/tui.scm
new file mode 100644
index 0000000000..8a8f80addf
--- /dev/null
+++ b/gnu/packages/tui.scm
@@ -0,0 +1,79 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2023 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages tui)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix utils)
+ #:use-module (guix gexp)
+ #:use-module (guix download)
+ #:use-module (guix git-download)
+ #:use-module (guix packages)
+ #:use-module (guix build-system cmake)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages check)
+ #:use-module (gnu packages version-control))
+
+(define-public ftxui
+ (package
+ (name "ftxui")
+ (version "3.0.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ArthurSonzogni/FTXUI")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32
+ "10a4yw2h29kixxyhll6cvrwyscsvz9asxry857a9l8nqvbhs946s"))
+ (file-name (git-file-name name version))))
+ (build-system cmake-build-system)
+ (native-inputs (list googletest))
+ (arguments
+ (list #:configure-flags
+ #~(list "-DFTXUI_BUILD_TESTS:BOOL=ON"
+ "-DFTXUI_BUILD_TESTS_FUZZER:BOOL=OFF")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-cmake-tests
+ (lambda _
+ (substitute* "cmake/ftxui_test.cmake"
+ (("NOT googletest_POPULATED")
+ "FALSE"))
+ ;; Disable benchmarks for a while as they require bundled Google
+ ;; benchmark and when the 'googlebenchmark' is unbundled, there's
+ ;; a CMake configuration error.
+ (substitute* "cmake/ftxui_benchmark.cmake"
+ (("NOT WIN32")
+ "FALSE")))) )))
+ (home-page "https://github.com/ArthurSonzogni/FTXUI")
+ (synopsis "C++ Functional Terminal User Interface")
+ (description
+ "Functional Terminal (X) User interface (FTXUI) is a simple C++ library for
+terminal based user interfaces.
+
+Main features:
+@itemize
+@item Functional style.
+@item Keyboard & mouse navigation.
+@item Support for UTF8 and fullwidth chars.
+@item Support for animations.
+@item Support for drawing.
+@item No dependencies.
+@end itemize")
+ (license license:expat)))
--
2.34.1
[-- Attachment #1.3: Type: text/plain, Size: 225 bytes --]
Thanks,
- avp
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#60567] [PATCH] gnu: Add ftxui
2023-01-08 17:06 ` Mathieu Othacehe
2023-01-08 17:49 ` Artyom V. Poptsov
@ 2023-01-08 17:52 ` Artyom V. Poptsov
2023-01-09 19:55 ` Artyom V. Poptsov
2 siblings, 0 replies; 7+ messages in thread
From: Artyom V. Poptsov @ 2023-01-08 17:52 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 60567
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
> I'm not sure about the new tui module because a lot of packages could
> fall into that category, all ncurses based programs for instance.
I'm not sure about the new module either, but where would you put this
package?
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#60567] [PATCH] gnu: Add ftxui
2023-01-08 17:06 ` Mathieu Othacehe
2023-01-08 17:49 ` Artyom V. Poptsov
2023-01-08 17:52 ` Artyom V. Poptsov
@ 2023-01-09 19:55 ` Artyom V. Poptsov
2023-01-10 8:16 ` bug#60567: " Mathieu Othacehe
2023-01-10 9:55 ` [bug#60567] " Mathieu Othacehe
2 siblings, 2 replies; 7+ messages in thread
From: Artyom V. Poptsov @ 2023-01-09 19:55 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 60567
[-- Attachment #1.1: Type: text/plain, Size: 117 bytes --]
Hello,
I decided to move the FTXUI package to "cpp.scm" module as the library
provides API mainly for C++ programs.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-ftxui.patch --]
[-- Type: text/x-diff, Size: 2566 bytes --]
From 74c0a34861242b913ab90ad77af9bdd778562016 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Thu, 5 Jan 2023 08:03:15 +0300
Subject: [PATCH] gnu: Add ftxui.
* gnu/packages/cpp.scm (ftxui): New variable.
---
gnu/packages/cpp.scm | 49 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index cc594e56c5..23ea05cf9e 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -2343,3 +2343,52 @@ (define-public wdl
@item And more.
@end itemize")
(license license:zlib))))
+
+(define-public ftxui
+ (package
+ (name "ftxui")
+ (version "3.0.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ArthurSonzogni/FTXUI")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32
+ "10a4yw2h29kixxyhll6cvrwyscsvz9asxry857a9l8nqvbhs946s"))
+ (file-name (git-file-name name version))))
+ (build-system cmake-build-system)
+ (native-inputs (list googletest))
+ (arguments
+ (list #:configure-flags
+ #~(list "-DFTXUI_BUILD_TESTS:BOOL=ON"
+ "-DFTXUI_BUILD_TESTS_FUZZER:BOOL=OFF")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-cmake-tests
+ (lambda _
+ (substitute* "cmake/ftxui_test.cmake"
+ (("NOT googletest_POPULATED")
+ "FALSE"))
+ ;; Disable benchmarks for a while as they require bundled Google
+ ;; benchmark and when the 'googlebenchmark' is unbundled, there's
+ ;; a CMake configuration error.
+ (substitute* "cmake/ftxui_benchmark.cmake"
+ (("NOT WIN32")
+ "FALSE")))) )))
+ (home-page "https://github.com/ArthurSonzogni/FTXUI")
+ (synopsis "C++ Functional Terminal User Interface")
+ (description
+ "Functional Terminal (X) User interface (FTXUI) is a simple C++ library for
+terminal based user interfaces.
+
+Main features:
+@itemize
+@item Functional style.
+@item Keyboard & mouse navigation.
+@item Support for UTF8 and fullwidth chars.
+@item Support for animations.
+@item Support for drawing.
+@item No dependencies.
+@end itemize")
+ (license license:expat)))
--
2.34.1
[-- Attachment #1.3: Type: text/plain, Size: 219 bytes --]
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#60567: [PATCH] gnu: Add ftxui
2023-01-09 19:55 ` Artyom V. Poptsov
@ 2023-01-10 8:16 ` Mathieu Othacehe
2023-01-10 9:55 ` [bug#60567] " Mathieu Othacehe
1 sibling, 0 replies; 7+ messages in thread
From: Mathieu Othacehe @ 2023-01-10 8:16 UTC (permalink / raw)
To: Artyom V. Poptsov; +Cc: 60567-done
Hell Artyom,
> I decided to move the FTXUI package to "cpp.scm" module as the library
> provides API mainly for C++ programs.
OK, thanks for the v2!
Applied.
Mathieu
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#60567] [PATCH] gnu: Add ftxui
2023-01-09 19:55 ` Artyom V. Poptsov
2023-01-10 8:16 ` bug#60567: " Mathieu Othacehe
@ 2023-01-10 9:55 ` Mathieu Othacehe
1 sibling, 0 replies; 7+ messages in thread
From: Mathieu Othacehe @ 2023-01-10 9:55 UTC (permalink / raw)
To: Artyom V. Poptsov; +Cc: 60567
Hey Artyom,
I noticed that the package is failing on non-x86_64 architectures:
https://ci.guix.gnu.org/eval/104402?status=failed.
Could you please have a look?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-01-10 10:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 5:42 [bug#60567] [PATCH] gnu: Add ftxui Artyom V. Poptsov
2023-01-08 17:06 ` Mathieu Othacehe
2023-01-08 17:49 ` Artyom V. Poptsov
2023-01-08 17:52 ` Artyom V. Poptsov
2023-01-09 19:55 ` Artyom V. Poptsov
2023-01-10 8:16 ` bug#60567: " Mathieu Othacehe
2023-01-10 9:55 ` [bug#60567] " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).