From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 59765@debbugs.gnu.org
Cc: phodina@protonmail.com
Subject: [bug#59765] Add Sourcetrail
Date: Sun, 23 Apr 2023 16:27:37 +0200 [thread overview]
Message-ID: <87cz3usmg6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <ATA5SJyXZ9f6XKftIRk4OdQUebQ-1m-OweW3XZgoQEn_TiC_ShsXfwdZXwd66tIF_zIyIv2nkoDybLflXj3e-t7rhI1l8Fh0Yjpzu08hLTw=@protonmail.com> (phodina via Guix-patches via's message of "Fri, 02 Dec 2022 07:18:38 +0000")
Hello,
phodina via Guix-patches via <guix-patches@gnu.org> writes:
> these patches add Sourcetrail code analysis tool,
Thank you.
> which unfortunately is not longer developed.
This doesn't sound too good. I notice there is a somewhat active fork at
<https://github.com/OpenSourceSourceTrail/Sourcetrail>. Would it make
sense to use it instead?
> +(define-public boost-for-sourcetrail
> + ;; Older version for Sourcetrail 1.1.30.
> + (package
> + (name "boost")
> + (version "1.67.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://sourceforge/boost/boost/" version "/boost_"
> + (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)
> + ".tar.bz2"))
> + (sha256
> + (base32
> + "1fmdlmkzsrd46wwk834jsi2ypxj68w2by0rfcg2pzrafk5rck116"))
> + (patches (search-patches "boost-fix-icu-build.patch"))))
> + (build-system gnu-build-system)
> + (inputs `(("icu4c" ,icu4c)
> + ("zlib" ,zlib)))
> + (native-inputs
> + `(("perl" ,perl)
> + ("python" ,python-2)
Guix has dropped support for Python 2, so this Boost package is not
really an option. Is it possible to use a more recent Boost library?
> +(define-public sourcetrail
> +(package
> + (name "sourcetrail")
> + (version "2021.1.30")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/CoatiSoftware/Sourcetrail")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0h0q2bfa6dv8hmc15rzj48bna1krzjwlcjm25dffbsi81xjcazb5"))))
> + (build-system cmake-build-system)
> + (arguments
> + (list #:configure-flags #~(list "-DBoost_USE_STATIC_LIBS=OFF" (string-append
> + "-DBOOST_ROOT=" #$(this-package-input "boost") "/lib"))
README mentions build process should also set Qt5_DIR configure flag.
> + #:phases
> + #~(modify-phases %standard-phases
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out #$output)
> + (prefix (string-append out "/opt/sourcetrail"))
> + (build (getcwd))
> + (share (string-append prefix "/share")))
> + (mkdir-p (string-append out "/bin"))
> + (install-file (string-append build "/app/Sourcetrail") (string-append
> + out "/bin"))
> + (install-file (string-append build
> + "/app/sourcetrail_indexer") (string-append
> + out "/bin"))))))))
Indentation is a bit off.
> + (native-inputs (list pkg-config))
> + (inputs (list boost-for-sourcetrail
> + qtbase-5
> + qtsvg-5))
> + (synopsis "Interactive source explorer")
> + (description "Offline source explorer that helps you get productive on unfamiliar source code with optional IDE integration.")
Description should consist of full sentences.
Although this review is a bit late, would you like to try sending an
updated patch?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2023-04-23 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 7:18 [bug#59765] Add Sourcetrail phodina via Guix-patches via
2023-04-23 14:27 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3usmg6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=59765@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).