From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oOEuMYNARWROGwEASxT56A (envelope-from ) for ; Sun, 23 Apr 2023 16:28:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0F4EMYNARWR0PgAA9RJhRA (envelope-from ) for ; Sun, 23 Apr 2023 16:28:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B3E9F168 for ; Sun, 23 Apr 2023 16:28:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqahB-0004hm-0i; Sun, 23 Apr 2023 10:28:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqah9-0004dy-0H for guix-patches@gnu.org; Sun, 23 Apr 2023 10:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqah8-0003EA-OF for guix-patches@gnu.org; Sun, 23 Apr 2023 10:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqah8-0001rN-8a for guix-patches@gnu.org; Sun, 23 Apr 2023 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59765] Add Sourcetrail Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Apr 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 59765@debbugs.gnu.org Cc: phodina@protonmail.com X-Debbugs-Original-To: phodina via Guix-patches via X-Debbugs-Original-Cc: 59765@debbugs.gnu.org, phodina Received: via spool by 59765-submit@debbugs.gnu.org id=B59765.16822600677107 (code B ref 59765); Sun, 23 Apr 2023 14:28:02 +0000 Received: (at 59765) by debbugs.gnu.org; 23 Apr 2023 14:27:47 +0000 Received: from localhost ([127.0.0.1]:46552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqagt-0001qY-13 for submit@debbugs.gnu.org; Sun, 23 Apr 2023 10:27:47 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqagq-0001qD-Ue for 59765@debbugs.gnu.org; Sun, 23 Apr 2023 10:27:45 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 578BC1BF206; Sun, 23 Apr 2023 14:27:38 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 23 Apr 2023 16:27:37 +0200 In-Reply-To: (phodina via Guix-patches via's message of "Fri, 02 Dec 2022 07:18:38 +0000") Message-ID: <87cz3usmg6.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682260099; a=rsa-sha256; cv=none; b=rM/r2Ur54a5SOJO+cpdzCjIuXbE/7jMTyF+d85TWUlYkQU7nugEy7gtwTrCSPUZjXuQWtX zQAmRHBzU0MG+ba7Ar4yUrxOGUIVIGqVluGW+ndOhbJR92j7ITrqR+OqLxWSt2SFOIUSr8 S/so+4m5hIBXdRO0dutsqqnFf/EY5sThPxI/cE6r6OPqv3uYBygFuWPIvKuqaMTc/oWjEC 026NLdYPQrlm9mcDM5c+dHU8REaM5WQANx2qkr0GGaDNdXh+Td0xXrQa4k+vblf9cSX5CR 4uUh+vB1v2NAsAQEP/DA3d+d4RUA6lmarqUzpry1ihlaq7tpyxNTIVlJhcoyPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682260099; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=QOd8ABiTOcFjdtetR1hwqfaATJjzgQUhk/Yp6BppLQQ=; b=R4e5Ehd1DFvwdxuRKVyBn2iVF4seTb1M500cSbbAIO3B4IiItr7la4YxfyMrczon+FFkrF 3ll0kGXjoQD89y8GMJaRLnpgY6W+C3nWRP5nElY1WoC4qkAHX4lBrGMTUiBUjRV/bPOPRE kDpzctflAQGUudFtqYXA4aoaZIsiWdvKWQq9B4e1ioOVKZzG6nW4nKnUzYld5BLrcyjRlI 55Ur5b9rHLkDsRMSMn2vuutqdkecaMWBgYWxlVsDhmn6ZqiyFvKquT5lmtG31pKNfb/1J2 kxsyRIes+IVtKr7MofXsSpJp8rwAZg4zEH/JxIpZrG8Ryn6BEJW7qJdTK1jhNg== X-Migadu-Spam-Score: -2.71 X-Spam-Score: -2.71 X-Migadu-Queue-Id: 6B3E9F168 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: m6Cnf6oPjbzq Hello, phodina via Guix-patches via writes: > these patches add Sourcetrail code analysis tool, Thank you. > which unfortunately is not longer developed. This doesn't sound too good. I notice there is a somewhat active fork at . Would it make sense to use it instead? > +(define-public boost-for-sourcetrail > + ;; Older version for Sourcetrail 1.1.30. > + (package > + (name "boost") > + (version "1.67.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://sourceforge/boost/boost/" version "/boost_" > + (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version) > + ".tar.bz2")) > + (sha256 > + (base32 > + "1fmdlmkzsrd46wwk834jsi2ypxj68w2by0rfcg2pzrafk5rck116")) > + (patches (search-patches "boost-fix-icu-build.patch")))) > + (build-system gnu-build-system) > + (inputs `(("icu4c" ,icu4c) > + ("zlib" ,zlib))) > + (native-inputs > + `(("perl" ,perl) > + ("python" ,python-2) Guix has dropped support for Python 2, so this Boost package is not really an option. Is it possible to use a more recent Boost library? > +(define-public sourcetrail > +(package > + (name "sourcetrail") > + (version "2021.1.30") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/CoatiSoftware/Sourcetrail") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0h0q2bfa6dv8hmc15rzj48bna1krzjwlcjm25dffbsi81xjcazb5")))) > + (build-system cmake-build-system) > + (arguments > + (list #:configure-flags #~(list "-DBoost_USE_STATIC_LIBS=OFF" (string-append > + "-DBOOST_ROOT=" #$(this-package-input "boost") "/lib")) README mentions build process should also set Qt5_DIR configure flag. > + #:phases > + #~(modify-phases %standard-phases > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out #$output) > + (prefix (string-append out "/opt/sourcetrail")) > + (build (getcwd)) > + (share (string-append prefix "/share"))) > + (mkdir-p (string-append out "/bin")) > + (install-file (string-append build "/app/Sourcetrail") (string-append > + out "/bin")) > + (install-file (string-append build > + "/app/sourcetrail_indexer") (string-append > + out "/bin")))))))) Indentation is a bit off. > + (native-inputs (list pkg-config)) > + (inputs (list boost-for-sourcetrail > + qtbase-5 > + qtsvg-5)) > + (synopsis "Interactive source explorer") > + (description "Offline source explorer that helps you get productive on unfamiliar source code with optional IDE integration.") Description should consist of full sentences. Although this review is a bit late, would you like to try sending an updated patch? Regards, -- Nicolas Goaziou