* [bug#29383] [PATCH] gnu: procmail: Fix CVE-2017-16844.
@ 2017-11-21 17:49 Leo Famulari
2017-11-21 21:09 ` Marius Bakke
0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2017-11-21 17:49 UTC (permalink / raw)
To: 29383
* gnu/packages/patches/procmail-CVE-2017-16844.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/mail.scm (procmail)[source]: Use it.
---
gnu/local.mk | 1 +
gnu/packages/mail.scm | 3 ++-
gnu/packages/patches/procmail-CVE-2017-16844.patch | 25 ++++++++++++++++++++++
3 files changed, 28 insertions(+), 1 deletion(-)
create mode 100644 gnu/packages/patches/procmail-CVE-2017-16844.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index f8e553965..0993c4587 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -978,6 +978,7 @@ dist_patch_DATA = \
%D%/packages/patches/portmidi-modular-build.patch \
%D%/packages/patches/procmail-ambiguous-getline-debian.patch \
%D%/packages/patches/procmail-CVE-2014-3618.patch \
+ %D%/packages/patches/procmail-CVE-2017-16844.patch \
%D%/packages/patches/proot-test-fhs.patch \
%D%/packages/patches/psm-arch.patch \
%D%/packages/patches/psm-ldflags.patch \
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 77d935171..38140d6e6 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1611,7 +1611,8 @@ deliver it in various ways.")
;; getline() in formail.c. The patch is provided by Debian as
;; patch 24.
(patches (search-patches "procmail-ambiguous-getline-debian.patch"
- "procmail-CVE-2014-3618.patch"))))
+ "procmail-CVE-2014-3618.patch"
+ "procmail-CVE-2017-16844.patch"))))
(arguments
`(#:phases (modify-phases %standard-phases
(replace 'configure
diff --git a/gnu/packages/patches/procmail-CVE-2017-16844.patch b/gnu/packages/patches/procmail-CVE-2017-16844.patch
new file mode 100644
index 000000000..b96540c8c
--- /dev/null
+++ b/gnu/packages/patches/procmail-CVE-2017-16844.patch
@@ -0,0 +1,25 @@
+Fix CVE-2017-16844:
+
+https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-16844
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876511
+
+Patch copied from Debian procmail package 3.22-26:
+
+http://http.debian.net/debian/pool/main/p/procmail/procmail_3.22-26.debian.tar.xz
+
+From: Santiago Vila <sanvila@debian.org>
+Subject: Fix heap-based buffer overflow in loadbuf()
+Bug-Debian: http://bugs.debian.org/876511
+X-Debian-version: 3.22-26
+
+--- a/src/formisc.c
++++ b/src/formisc.c
+@@ -103,7 +103,7 @@
+ }
+ /* append to buf */
+ void loadbuf(text,len)const char*const text;const size_t len;
+-{ if(buffilled+len>buflen) /* buf can't hold the text */
++{ while(buffilled+len>buflen) /* buf can't hold the text */
+ buf=realloc(buf,buflen+=Bsize);
+ tmemmove(buf+buffilled,text,len);buffilled+=len;
+ }
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#29383] [PATCH] gnu: procmail: Fix CVE-2017-16844.
2017-11-21 17:49 [bug#29383] [PATCH] gnu: procmail: Fix CVE-2017-16844 Leo Famulari
@ 2017-11-21 21:09 ` Marius Bakke
2017-11-22 2:59 ` bug#29383: " Leo Famulari
0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2017-11-21 21:09 UTC (permalink / raw)
To: Leo Famulari, 29383
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
Leo Famulari <leo@famulari.name> writes:
> * gnu/packages/patches/procmail-CVE-2017-16844.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/mail.scm (procmail)[source]: Use it.
LGTM, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29383: [PATCH] gnu: procmail: Fix CVE-2017-16844.
2017-11-21 21:09 ` Marius Bakke
@ 2017-11-22 2:59 ` Leo Famulari
0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2017-11-22 2:59 UTC (permalink / raw)
Cc: 29383-done
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
On Tue, Nov 21, 2017 at 10:09:41PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
>
> > * gnu/packages/patches/procmail-CVE-2017-16844.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
> > * gnu/packages/mail.scm (procmail)[source]: Use it.
>
> LGTM, thanks!
Closed with commit c297e965d51a332b15bccbb180d6f9a400cb8805.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-22 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-21 17:49 [bug#29383] [PATCH] gnu: procmail: Fix CVE-2017-16844 Leo Famulari
2017-11-21 21:09 ` Marius Bakke
2017-11-22 2:59 ` bug#29383: " Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).