[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[Fis Trivial]

* gnu/packages/check.scm (python-pyhamcrest): New variable.
---
 gnu/packages/check.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 05ed3eea3..a7ddc01ce 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1766,3 +1766,37 @@ retried.")

 (define-public python2-flaky
   (package-with-python2 python-flaky))
+
+(define-public python-pyhamcrest
+  (package
+    (name "python-pyhamcrest")
+    (version "1.9.0")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append
+                "https://github.com/hamcrest/PyHamcrest/archive/V"
+                version
+                ".tar.gz"))
+              (file-name
+               (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1lqjajhwf7x7igvvnj5p1cm31y9njy07qby94w18kl6zwbdjqrwy"))))
+    (native-inputs                      ; All native inputs are for tests
+     `(("python-pytest-cov" ,python-pytest-cov)
+       ("python-mock" ,python-mock)
+       ("python-pytest" ,python-pytest-3.0)
+       ("python-hypothesis" ,python-hypothesis)))
+    (inputs
+     `(("python-six" ,python-six)))
+    (build-system python-build-system)
+    (home-page "http://hamcrest.org/")
+    (synopsis "Hamcrest matchers for Python")
+    (description
+     "PyHamcrest is a framework for writing matcher objects,
+ allowing you to declaratively define \"match\" rules.")
+    (license license:bsd-3)))
+
+(define-public python2-pyhamcrest
+  (package-with-python2 python-pyhamcrest))
-- 
2.13.6

[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]

Hi Fis,

> * gnu/packages/check.scm (python-pyhamcrest): New variable.
> ---
>  gnu/packages/check.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 05ed3eea3..a7ddc01ce 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -1766,3 +1766,37 @@ retried.")
>
>  (define-public python2-flaky
>    (package-with-python2 python-flaky))
> +
> +(define-public python-pyhamcrest
> +  (package
> +    (name "python-pyhamcrest")
> +    (version "1.9.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append
> +                "https://github.com/hamcrest/PyHamcrest/archive/V"
> +                version
> +                ".tar.gz"))

".tar.gz" can share the line with the version number here.

> +              (file-name
> +               (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1lqjajhwf7x7igvvnj5p1cm31y9njy07qby94w18kl6zwbdjqrwy"))))
> +    (native-inputs                      ; All native inputs are for tests
> +     `(("python-pytest-cov" ,python-pytest-cov)
> +       ("python-mock" ,python-mock)
> +       ("python-pytest" ,python-pytest-3.0)
> +       ("python-hypothesis" ,python-hypothesis)))
> +    (inputs
> +     `(("python-six" ,python-six)))

Six would be a propagated input here, seeing that it is in the
install_requires list in Hamcrest's setup.py file. For more details and
future reference, this type of thing is in the "Python Modules" section
of Guix's manual.

> +    (build-system python-build-system)
> +    (home-page "http://hamcrest.org/")
> +    (synopsis "Hamcrest matchers for Python")
> +    (description
> +     "PyHamcrest is a framework for writing matcher objects,
> + allowing you to declaratively define \"match\" rules.")
> +    (license license:bsd-3)))
> +
> +(define-public python2-pyhamcrest
> +  (package-with-python2 python-pyhamcrest))

I've also added python2-hamcrest to the list of new variables in your
commit message. I've made changed the bits I mentioned above and pushed
your changes. Thanks for contributing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#29915: [PATCH] gnu: Add python-pyhamcrest.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 2517 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> Hi Fis,
>
>> * gnu/packages/check.scm (python-pyhamcrest): New variable.
>> ---
>>  gnu/packages/check.scm | 34 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>
>> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
>> index 05ed3eea3..a7ddc01ce 100644
>> --- a/gnu/packages/check.scm
>> +++ b/gnu/packages/check.scm
>> @@ -1766,3 +1766,37 @@ retried.")
>>
>>  (define-public python2-flaky
>>    (package-with-python2 python-flaky))
>> +
>> +(define-public python-pyhamcrest
>> +  (package
>> +    (name "python-pyhamcrest")
>> +    (version "1.9.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri
>> +               (string-append
>> +                "https://github.com/hamcrest/PyHamcrest/archive/V"
>> +                version
>> +                ".tar.gz"))
>
> ".tar.gz" can share the line with the version number here.
>
>> +              (file-name
>> +               (string-append name "-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1lqjajhwf7x7igvvnj5p1cm31y9njy07qby94w18kl6zwbdjqrwy"))))
>> +    (native-inputs                      ; All native inputs are for tests
>> +     `(("python-pytest-cov" ,python-pytest-cov)
>> +       ("python-mock" ,python-mock)
>> +       ("python-pytest" ,python-pytest-3.0)
>> +       ("python-hypothesis" ,python-hypothesis)))
>> +    (inputs
>> +     `(("python-six" ,python-six)))
>
> Six would be a propagated input here, seeing that it is in the
> install_requires list in Hamcrest's setup.py file. For more details and
> future reference, this type of thing is in the "Python Modules" section
> of Guix's manual.
>
>> +    (build-system python-build-system)
>> +    (home-page "http://hamcrest.org/")
>> +    (synopsis "Hamcrest matchers for Python")
>> +    (description
>> +     "PyHamcrest is a framework for writing matcher objects,
>> + allowing you to declaratively define \"match\" rules.")
>> +    (license license:bsd-3)))
>> +
>> +(define-public python2-pyhamcrest
>> +  (package-with-python2 python-pyhamcrest))
>
> I've also added python2-hamcrest to the list of new variables in your
> commit message. I've made changed the bits I mentioned above and pushed
> your changes. Thanks for contributing!

Also, if a copyright attribution is not already present, don't forget to
add a copyright line at the top of the file for yourself when making
copyrightable contributions like this one!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[Fis Trivial]

> 
> Also, if a copyright attribution is not already present, don't forget to
> add a copyright line at the top of the file for yourself when making
> copyrightable contributions like this one!
> 

Thanks. Will do. :-)

[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[Fis Trivial]

> 
> Six would be a propagated input here, seeing that it is in the
> install_requires list in Hamcrest's setup.py file. For more details and
> future reference, this type of thing is in the "Python Modules" section
> of Guix's manual.
> 

For reasons I don't know(I am new to guix, sorry about that). I added six
because without it, the build phase failed on my device.

> 
> I've also added python2-hamcrest to the list of new variables in your
> commit message. I've made changed the bits I mentioned above and pushed
> your changes. Thanks for contributing!
> 

Thanks.

[bug#29915] [PATCH] gnu: Add python-pyhamcrest.

[Fis Trivial]

> 
> Six would be a propagated input here, seeing that it is in the
> install_requires list in Hamcrest's setup.py file. For more details and
> future reference, this type of thing is in the "Python Modules" section
> of Guix's manual.
> 
I dig through the menu. Now I understand what you mean by that.

Thanks for the advice.