unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: amirouche@hyper.dev
Cc: 35518@debbugs.gnu.org
Subject: [bug#35518] gnu: guile-pfds bugfix
Date: Mon, 06 May 2019 10:05:30 +0200	[thread overview]
Message-ID: <87bm0gnh2t.fsf@gnu.org> (raw)
In-Reply-To: <3279cee19940b90be0bbe34b6619fe89@hyper.dev> (amirouche@hyper.dev's message of "Wed, 01 May 2019 13:46:59 +0200")

Hi Amirouche,

amirouche@hyper.dev skribis:

> On 2019-05-01 08:20, Ricardo Wurmus wrote:
>>
>> I’d prefer not to add a patch file here but to add a build phase after
>> unpack that uses substitute* to patch the file.
>>
>
> new patch
>
> From de22b734f37c2701121b990fe1fda5ead67ece31 Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche+dev@hyper.dev>
> Date: Wed, 1 May 2019 13:41:59 +0200
> Subject: [PATCH] gnu: guile-pfds bugfix
>
> - gnu/packages/guile-xyz.scm(guile-pfds)[version]: upgrade to 0.3-0
> - gnu/packages/guile-xyz.scm(guile-pfds)[commit]: hardcode v0.3
> - gnu/packages/guile-xyz.scm(guile-pfds)[arguments]: New phase 'patch'

[...]

> +                  (add-after 'unpack 'patch
> +                    (lambda _
> +                      (substitute* "hamts.sls"
> +                        (("subtrie-vector vector")
> +                         "subtrie-vector trie"))
> +                        #t))

Like Ricardo wrote: “there should be a note about the upstream status of
this change.”  Someone reading this cannot understand what this change
is about nor what upstream thinks about it.

Could you address this issue?

Bonus points if you change it to follow our conventions for the commit
log and for the Git checkouts.  :-)

  https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html
  https://www.gnu.org/software/guix/manual/en/html_node/Version-Numbers.html

Thanks in advance,
Ludo’.

  reply	other threads:[~2019-05-06  8:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  0:52 [bug#35518] gnu: guile-pfds bugfix amirouche
2019-05-01  3:42 ` [bug#35518] (no subject) amirouche
2019-05-06 11:09   ` Ricardo Wurmus
2019-05-06 12:42     ` [bug#35518] [PATCH] fix guile-pfds bug amirouche
2019-05-06 13:10       ` Ricardo Wurmus
2021-07-14  2:43       ` bug#35518: gnu: guile-pfds bugfix Maxim Cournoyer
2019-05-01  6:20 ` [bug#35518] " Ricardo Wurmus
2019-05-01 10:58   ` amirouche
2019-05-01 11:46   ` amirouche
2019-05-06  8:05     ` Ludovic Courtès [this message]
2019-05-06  8:05     ` Ludovic Courtès
2019-06-26  1:47 ` [bug#35518] upstream unresponsive Amirouche
2020-06-06  3:33 ` [bug#35518] guile-pfds hamts fix Jack Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm0gnh2t.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35518@debbugs.gnu.org \
    --cc=amirouche@hyper.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).