From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:46110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYdP-0000Tc-MZ
	for guix-patches@gnu.org; Mon, 06 May 2019 04:06:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYdO-0007NT-Iu
	for guix-patches@gnu.org; Mon, 06 May 2019 04:06:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42092)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hNYdO-0007NO-FM
	for guix-patches@gnu.org; Mon, 06 May 2019 04:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYdO-0004F6-7z
	for guix-patches@gnu.org; Mon, 06 May 2019 04:06:02 -0400
Subject: [bug#35518] gnu: guile-pfds bugfix
Resent-Message-ID: <handler.35518.B35518.155712996016300@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <141212fdb5356cbf7ad955a70bc26379@hyper.dev>
	<87imuuvgpd.fsf@elephly.net>
	<3279cee19940b90be0bbe34b6619fe89@hyper.dev>
Date: Mon, 06 May 2019 10:05:30 +0200
In-Reply-To: <3279cee19940b90be0bbe34b6619fe89@hyper.dev>
	(amirouche@hyper.dev's message of "Wed, 01 May 2019 13:46:59 +0200")
Message-ID: <87bm0gnh2t.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: amirouche@hyper.dev
Cc: 35518@debbugs.gnu.org

Hi Amirouche,

amirouche@hyper.dev skribis:

> On 2019-05-01 08:20, Ricardo Wurmus wrote:
>>
>> I=E2=80=99d prefer not to add a patch file here but to add a build phase=
 after
>> unpack that uses substitute* to patch the file.
>>
>
> new patch
>
> From de22b734f37c2701121b990fe1fda5ead67ece31 Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche+dev@hyper.dev>
> Date: Wed, 1 May 2019 13:41:59 +0200
> Subject: [PATCH] gnu: guile-pfds bugfix
>
> - gnu/packages/guile-xyz.scm(guile-pfds)[version]: upgrade to 0.3-0
> - gnu/packages/guile-xyz.scm(guile-pfds)[commit]: hardcode v0.3
> - gnu/packages/guile-xyz.scm(guile-pfds)[arguments]: New phase 'patch'

[...]

> +                  (add-after 'unpack 'patch
> +                    (lambda _
> +                      (substitute* "hamts.sls"
> +                        (("subtrie-vector vector")
> +                         "subtrie-vector trie"))
> +                        #t))

Like Ricardo wrote: =E2=80=9Cthere should be a note about the upstream stat=
us of
this change.=E2=80=9D  Someone reading this cannot understand what this cha=
nge
is about nor what upstream thinks about it.

Could you address this issue?

Bonus points if you change it to follow our conventions for the commit
log and for the Git checkouts.  :-)

  https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.=
html
  https://www.gnu.org/software/guix/manual/en/html_node/Version-Numbers.html

Thanks in advance,
Ludo=E2=80=99.