From: "Ludovic Courtès" <ludo@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 36615@debbugs.gnu.org
Subject: [bug#36615] [PATCH] gnu: Add opencascade-occt.
Date: Fri, 12 Jul 2019 23:51:31 +0200 [thread overview]
Message-ID: <87blxydiqk.fsf@gnu.org> (raw)
In-Reply-To: <1562926068-5497-1-git-send-email-pgarlick@tourbillion-technology.com> (Paul Garlick's message of "Fri, 12 Jul 2019 11:07:48 +0100")
Hi Paul,
Paul Garlick <pgarlick@tourbillion-technology.com> skribis:
> * gnu/packages/maths.scm (opencascade-occt): New variable.
[...]
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://git.dev.opencascade.org/gitweb/?p=occt.git;"
> + "a=snapshot;sf=tgz;h=refs/tags/V"
> + (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)))
I think you should use ‘git-fetch’ instead because generated tarballs
are notoriously prone to silent change.
> + (arguments
> + '(;; There is no test target for make.
> + #:tests? #f
Sometimes CMake-based packages have a configure-time option like
-DWITH_TESTS=ON. Is there something like that here?
Apart from that it LGTM. Thank you!
Ludo’.
next prev parent reply other threads:[~2019-07-12 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 10:07 [bug#36615] [PATCH] gnu: Add opencascade-occt Paul Garlick
2019-07-12 21:51 ` Ludovic Courtès [this message]
2019-07-15 18:33 ` Paul Garlick
2019-07-15 19:59 ` Ludovic Courtès
2019-07-16 21:32 ` Paul Garlick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxydiqk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=36615@debbugs.gnu.org \
--cc=pgarlick@tourbillion-technology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).