From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:55704)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hm3SX-0006Qu-Oq
 for guix-patches@gnu.org; Fri, 12 Jul 2019 17:52:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hm3SV-0006TB-SJ
 for guix-patches@gnu.org; Fri, 12 Jul 2019 17:52:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60303)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hm3ST-0006Nx-WF
 for guix-patches@gnu.org; Fri, 12 Jul 2019 17:52:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hm3ST-0006dn-U7
 for guix-patches@gnu.org; Fri, 12 Jul 2019 17:52:01 -0400
Subject: [bug#36615] [PATCH] gnu: Add opencascade-occt.
Resent-Message-ID: <handler.36615.B36615.156296830525503@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <1562926068-5497-1-git-send-email-pgarlick@tourbillion-technology.com>
Date: Fri, 12 Jul 2019 23:51:31 +0200
In-Reply-To: <1562926068-5497-1-git-send-email-pgarlick@tourbillion-technology.com>
 (Paul Garlick's message of "Fri, 12 Jul 2019 11:07:48 +0100")
Message-ID: <87blxydiqk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 36615@debbugs.gnu.org

Hi Paul,

Paul Garlick <pgarlick@tourbillion-technology.com> skribis:

> * gnu/packages/maths.scm (opencascade-occt): New variable.

[...]

> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +              "https://git.dev.opencascade.org/gitweb/?p=3Docct.git;"
> +              "a=3Dsnapshot;sf=3Dtgz;h=3Drefs/tags/V"
> +              (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)))

I think you should use =E2=80=98git-fetch=E2=80=99 instead because generate=
d tarballs
are notoriously prone to silent change.

> +    (arguments
> +     '(;; There is no test target for make.
> +       #:tests? #f

Sometimes CMake-based packages have a configure-time option like
-DWITH_TESTS=3DON.  Is there something like that here?

Apart from that it LGTM.  Thank you!

Ludo=E2=80=99.