From: "Ludovic Courtès" <ludo@gnu.org>
To: Giacomo Leidi <goodoldpaul@autistici.org>
Cc: 36658@debbugs.gnu.org
Subject: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Wed, 17 Jul 2019 15:35:14 +0200 [thread overview]
Message-ID: <87blxsbx7x.fsf@gnu.org> (raw)
In-Reply-To: <20190715092818.2490-1-goodoldpaul@autistici.org> (Giacomo Leidi's message of "Mon, 15 Jul 2019 11:28:18 +0200")
Hello,
Giacomo Leidi <goodoldpaul@autistici.org> skribis:
> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.
Thanks for this patch! Below are a couple of suggestions.
> +(define-public emacs-zerodark-theme
> + (package
> + (name "emacs-zerodark-theme")
^
The indentation is off here (you can do M-q to fix it if you use
paredit).
> + (version "20190528.923")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://melpa.org/packages/zerodark-theme-"
> + version
> + ".el"))
This URL is unstable: the file will be modified in place regularly.
Consequently, could you instead use the upstream Git repository URL
along with the ‘git-fetch’ method?
> + (synopsis
> + "A dark, medium contrast theme for Emacs")
^
Please remove “A”, as suggested by ‘guix lint’.
> + (description
> + "A dark theme inspired from One Dark and Niflheim.
Please write a full sentence (info "(guix) Synopses and Descriptions").
> +An optional mode-line format can be enabled with 'zerodark-setup-modeline-format'.")
^
Please use @code as suggested by ‘guix lint’.
Could you send an updated patch?
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-07-17 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:28 [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme Giacomo Leidi
2019-07-17 13:35 ` Ludovic Courtès [this message]
2019-07-19 10:30 ` Tino il Cotechino
2019-07-19 22:59 ` bug#36658: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxsbx7x.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=36658@debbugs.gnu.org \
--cc=goodoldpaul@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).