From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53154)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hnk6F-0001E4-8U
 for guix-patches@gnu.org; Wed, 17 Jul 2019 09:36:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hnk6E-0006WN-50
 for guix-patches@gnu.org; Wed, 17 Jul 2019 09:36:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42892)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hnk6E-0006WF-1b
 for guix-patches@gnu.org; Wed, 17 Jul 2019 09:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hnk6D-0005T9-SD
 for guix-patches@gnu.org; Wed, 17 Jul 2019 09:36:01 -0400
Subject: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Resent-Message-ID: <handler.36658.B36658.156337052420970@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190715092818.2490-1-goodoldpaul@autistici.org>
Date: Wed, 17 Jul 2019 15:35:14 +0200
In-Reply-To: <20190715092818.2490-1-goodoldpaul@autistici.org> (Giacomo
 Leidi's message of "Mon, 15 Jul 2019 11:28:18 +0200")
Message-ID: <87blxsbx7x.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Giacomo Leidi <goodoldpaul@autistici.org>
Cc: 36658@debbugs.gnu.org

Hello,

Giacomo Leidi <goodoldpaul@autistici.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.

Thanks for this patch!  Below are a couple of suggestions.

> +(define-public emacs-zerodark-theme
> +  (package
> +  (name "emacs-zerodark-theme")
     ^
The indentation is off here (you can do M-q to fix it if you use
paredit).

> +  (version "20190528.923")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "https://melpa.org/packages/zerodark-theme-"
> +             version
> +             ".el"))

This URL is unstable: the file will be modified in place regularly.
Consequently, could you instead use the upstream Git repository URL
along with the =E2=80=98git-fetch=E2=80=99 method?

> +  (synopsis
> +    "A dark, medium contrast theme for Emacs")
        ^
Please remove =E2=80=9CA=E2=80=9D, as suggested by =E2=80=98guix lint=E2=80=
=99.

> +  (description
> +    "A dark theme inspired from One Dark and Niflheim.

Please write a full sentence (info "(guix) Synopses and Descriptions").

> +An optional mode-line format can be enabled with 'zerodark-setup-modelin=
e-format'.")
                                                    ^
Please use @code as suggested by =E2=80=98guix lint=E2=80=99.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.