unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40440@debbugs.gnu.org
Subject: [bug#40440] [PATCH 2/3] gnu: Add mruby-zest.
Date: Tue, 14 Apr 2020 19:41:51 +0100	[thread overview]
Message-ID: <87blnt7vv4.fsf@cbaines.net> (raw)
In-Reply-To: <dfcc38290135d0438a9d322426e7d0d3628a7195.camel@zrythm.org>

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]


Alexandros Theodotou <alex@zrythm.org> writes:

> This patch adds mruby-zest, a dependency of zynfusion. I had some help
> from the developer for making it build without connecting to the
> internet.

Hey Alex,

Thanks for taking the time to package mruby-zest.

> +(define-public mruby-zest
> +  (package
> +    (name "mruby-zest")
> +    (version "3.0.5-ba39aabd")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               ;; this is a meta repo that packs the mruby dependencies
> +               ;; as submodules
> +               (url "https://github.com/mruby-zest/mruby-zest-build.git")
> +               ;; ghaction branch - suggested by the developer to avoid
> +               ;; automatic downloading of some unneeded and
> +               ;; hard-to-package dependencies used for debugging
> +               (commit  "ba39aabd8d4ddc5f14137083b6f9a96c536f5f12")
> +               (recursive? #t)))

So I spotted the use of a "deps" directory, which is a bad sign, as
dependencies should be other packages, not things as part of this
package.

I then spotted that the source for this package isn't the upstream Git
repository, but a Git repository that pulls together the mruby-zest
source code, with code from ~16 other Git repositories.

Would it be possible to create Guix packages for these dependencies?

I know that would involve quite a bit of work, but unfortunately that
kind of work is necessary to ensure Guix as a collection of packages can
be maintained in the long term.

> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32
> +          "1vqzdds30sr982dp7fclg4r19l44rv8pbz6h4a8vcginj494gvjn"))))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2020-04-14 18:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04 21:10 [bug#40440] [PATCH 2/3] gnu: Add mruby-zest Alexandros Theodotou
2020-04-14 18:41 ` Christopher Baines [this message]
2020-04-14 18:48   ` Alexandros Theodotou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blnt7vv4.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=40440@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).