From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34075) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOQVX-0000SN-8z for guix-patches@gnu.org; Tue, 14 Apr 2020 14:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOQVW-0002Mk-0G for guix-patches@gnu.org; Tue, 14 Apr 2020 14:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOQVV-0002Me-SY for guix-patches@gnu.org; Tue, 14 Apr 2020 14:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOQVV-000093-Qs for guix-patches@gnu.org; Tue, 14 Apr 2020 14:42:01 -0400 Subject: [bug#40440] [PATCH 2/3] gnu: Add mruby-zest. Resent-Message-ID: References: From: Christopher Baines In-reply-to: Date: Tue, 14 Apr 2020 19:41:51 +0100 Message-ID: <87blnt7vv4.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandros Theodotou Cc: 40440@debbugs.gnu.org --=-=-= Content-Type: text/plain Alexandros Theodotou writes: > This patch adds mruby-zest, a dependency of zynfusion. I had some help > from the developer for making it build without connecting to the > internet. Hey Alex, Thanks for taking the time to package mruby-zest. > +(define-public mruby-zest > + (package > + (name "mruby-zest") > + (version "3.0.5-ba39aabd") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + ;; this is a meta repo that packs the mruby dependencies > + ;; as submodules > + (url "https://github.com/mruby-zest/mruby-zest-build.git") > + ;; ghaction branch - suggested by the developer to avoid > + ;; automatic downloading of some unneeded and > + ;; hard-to-package dependencies used for debugging > + (commit "ba39aabd8d4ddc5f14137083b6f9a96c536f5f12") > + (recursive? #t))) So I spotted the use of a "deps" directory, which is a bad sign, as dependencies should be other packages, not things as part of this package. I then spotted that the source for this package isn't the upstream Git repository, but a Git repository that pulls together the mruby-zest source code, with code from ~16 other Git repositories. Would it be possible to create Guix packages for these dependencies? I know that would involve quite a bit of work, but unfortunately that kind of work is necessary to ensure Guix as a collection of packages can be maintained in the long term. > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1vqzdds30sr982dp7fclg4r19l44rv8pbz6h4a8vcginj494gvjn")))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6WA+9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdvNQ//fG8rO90rsWY9X9AwC2q2uMkrCRrzdlJmRygn7rbdJ7K2YMzcNiczpKBC fY49IJKyYQCcR2Whznqgzv1G26YNCQvCe17q9yJfFIP5TZOyG7DuTef8v53IlHGM QsOz/AEJLcAQmziqhGUhPSeEwA8RfELXOc7asEe5MAJ3Yz5ffD3cXO9JAkOkumaD 5/dnGWN+VrjxWDaTPXVrAMn89FoZB34gL3xQaRCCXispFJlbRrmPEoTNozW4Za3I 4xtgoscEDD8LgmtsX2SpMBlZSzxnDtLB04yoYgzkOpW8d4/4splmVMEoQ3RSSGQP AYaYCm+2mZetMo/Oms0kYOwgE1SnaYFGtYjT1h5esIRML8xb6K1SQCBe41P0pf7l H5naeUM+Y9ptbkRkvyIeMNyEMH4JQQ/OiyUjKeFAcG0x0/LWLG2487hNf5bgNPOk k6620vuSB/3Q8/+GH7FDIrhtOqJPhEaaVPlApn7gEVW5MAE6vCHWZUdhGUFw/L/M E6ASXtxyRnTAzTwpf92v9nUra1yCxq2ArtRDCxTSe2WEBR0z1dZD0QDH+27S7aZ0 s+K6FHpP7I/WNHHBabAB6KZbCUFCGm2AwUDsfr+X14bpuxrIsyhPkS3sacXedncY z3yllvxbfhJ+zIpVFNaznW1DsAQMeAjOk9Et66f5rOjYrGYY1q0= =yMA1 -----END PGP SIGNATURE----- --=-=-=--