unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 43170@debbugs.gnu.org
Subject: [bug#43170] [PATCH 1/2] ui: Refactor the package-strings helper in show-manifest-transaction.
Date: Fri, 04 Sep 2020 10:47:28 +0200	[thread overview]
Message-ID: <87blimvsgv.fsf@gnu.org> (raw)
In-Reply-To: <20200902172046.3728-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 2 Sep 2020 13:20:46 -0400")

Hi!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * guix/ui.scm (show-manifest-transaction)[package-strings]: Add an
> OLD-VERSIONS keyword parameter.  Absorb the code path previously found in the
> upgrade-string.  Remove upgrade-string.
> (show-manifest-transaction): Adjust to the above changes.

[...]

> * guix/ui.scm (show-manifest-transaction): Sort entries to be displayed in a
> tabulated view.

LGTM, thanks!

Ludo’.




      parent reply	other threads:[~2020-09-04  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 17:20 [bug#43170] [PATCH 1/2] ui: Refactor the package-strings helper in show-manifest-transaction Maxim Cournoyer
2020-09-02 17:22 ` [bug#43170] [PATCH 2/2] ui: Lexicographically sort transaction entries based on their package name Maxim Cournoyer
     [not found]   ` <handler.43171.B.159906734217257.ack@debbugs.gnu.org>
2020-09-02 17:25     ` bug#43171: Acknowledgement ([PATCH 2/2] ui: Lexicographically sort transaction entries based on their package name.) Maxim Cournoyer
2020-09-04  8:47 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blimvsgv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43170@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).