From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8ONSH0r/UV9dMAAA0tVLHw (envelope-from ) for ; Fri, 04 Sep 2020 08:48:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4EtoG0r/UV9JbQAA1q6Kng (envelope-from ) for ; Fri, 04 Sep 2020 08:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CEA79406B8 for ; Fri, 4 Sep 2020 08:48:10 +0000 (UTC) Received: from localhost ([::1]:36964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE7OD-00066w-3X for larch@yhetil.org; Fri, 04 Sep 2020 04:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE7O6-00066k-IR for guix-patches@gnu.org; Fri, 04 Sep 2020 04:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE7O6-0006Yz-A2 for guix-patches@gnu.org; Fri, 04 Sep 2020 04:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kE7O6-0008GA-8N for guix-patches@gnu.org; Fri, 04 Sep 2020 04:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43170] [PATCH 1/2] ui: Refactor the package-strings helper in show-manifest-transaction. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Sep 2020 08:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 43170@debbugs.gnu.org Received: via spool by 43170-submit@debbugs.gnu.org id=B43170.159920926031717 (code B ref 43170); Fri, 04 Sep 2020 08:48:02 +0000 Received: (at 43170) by debbugs.gnu.org; 4 Sep 2020 08:47:40 +0000 Received: from localhost ([127.0.0.1]:37250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE7Nk-0008FV-1i for submit@debbugs.gnu.org; Fri, 04 Sep 2020 04:47:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE7Ni-0008FJ-9K for 43170@debbugs.gnu.org; Fri, 04 Sep 2020 04:47:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54911) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE7Nc-0006We-WB; Fri, 04 Sep 2020 04:47:33 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46366 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE7Nc-0008Ea-Ij; Fri, 04 Sep 2020 04:47:32 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200902172046.3728-1-maxim.cournoyer@gmail.com> Date: Fri, 04 Sep 2020 10:47:28 +0200 In-Reply-To: <20200902172046.3728-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 2 Sep 2020 13:20:46 -0400") Message-ID: <87blimvsgv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: PaFdHCADfAe7 Hi! Maxim Cournoyer skribis: > * guix/ui.scm (show-manifest-transaction)[package-strings]: Add an > OLD-VERSIONS keyword parameter. Absorb the code path previously found in= the > upgrade-string. Remove upgrade-string. > (show-manifest-transaction): Adjust to the above changes. [...] > * guix/ui.scm (show-manifest-transaction): Sort entries to be displayed i= n a > tabulated view. LGTM, thanks! Ludo=E2=80=99.