From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 44800@debbugs.gnu.org
Subject: [bug#44800] [PATCH v2 2/3] publish: Add avahi support.
Date: Fri, 27 Nov 2020 18:12:25 +0100 [thread overview]
Message-ID: <87blfisozq.fsf@gnu.org> (raw)
In-Reply-To: <20201124132145.217751-3-othacehe@gnu.org> (Mathieu Othacehe's message of "Tue, 24 Nov 2020 14:21:44 +0100")
Hi,
Mathieu Othacehe <othacehe@gnu.org> skribis:
> * guix/scripts/publish.scm (%options): Add "--enable-avahi" option.
> (show-help): Document it.
> (service-name): New procedure,
> (publish-service-type): new variable.
> (run-publish-server): Add "avahi?" and "port" parameters. Use them to publish
> the server using Avahi.
> (guix-publish): Pass the "avahi?" option to "run-publish-server".
> * gnu/services/base.scm (<guix-publish-configuration>): Add "enable-avahi?"
> field.
> (guix-publish-shepherd-service): Honor it.
Neat!
> +When the @option{--enable-avahi} option is passed, the publish server is
> +advertised on the local network as an Avahi service, using Guile-Avahi
> +bindings.
s/bindings/(@pxref{Top,,, guile-avahi, Using Avahi in Guile Scheme Programs}/
As discussed on IRC, I would avoid using the name Avahi on the CLI and
to some extent in the API as well. The command-line option could be
“--advertise”.
The documentation would be something like:
… the server advertises its availability on the local network using
multicast DNS (mDNS) and DNS service discovery (DNS-SD), currently
@i{via} Guile-Avahi …
(I remember that Julien posted a DNS client implementation a few years
ago, we never know what the future will be like… :-))
> + (enable-avahi? guix-publish-enable-avahi? ;boolean
> + (default #f))
Same here.
> (define* (run-publish-server socket store
> #:key
> + avahi? port
> (compressions (list %no-compression))
> (nar-path "nar") narinfo-ttl
> cache pool)
> + (when avahi?
> + (avahi-publish-service-thread (service-name)
> + #:type publish-service-type
> + #:port port))
Maybe add (info (_ "advertising …")) here. Ideally, you’d need a
callback because you can’t tell what the actual advertised name is since
Avahi can pick one to avoid name clashes.
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-11-27 17:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 15:56 [bug#44800] [PATCH 0/2] publish: Add Avahi support Mathieu Othacehe
2020-11-22 15:56 ` [bug#44802] [PATCH 1/2] " Mathieu Othacehe
2020-11-22 15:56 ` [bug#44801] [PATCH 2/2] publish: Add avahi support Mathieu Othacehe
2020-11-23 22:04 ` [bug#44800] [PATCH 0/2] publish: Add Avahi support zimoun
2020-11-24 13:35 ` Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 0/3] " Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 1/3] " Mathieu Othacehe
2020-11-27 17:04 ` Ludovic Courtès
2020-11-27 17:09 ` zimoun
2020-11-28 11:02 ` Ludovic Courtès
2020-11-28 18:59 ` zimoun
2020-11-29 14:18 ` Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 2/3] publish: Add avahi support Mathieu Othacehe
2020-11-27 17:12 ` Ludovic Courtès [this message]
2020-11-29 14:19 ` Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 3/3] Use substitute servers on the local network Mathieu Othacehe
2020-11-27 17:37 ` Ludovic Courtès
2020-11-29 14:29 ` Mathieu Othacehe
2020-11-30 13:46 ` Ludovic Courtès
2020-12-01 8:43 ` bug#44800: " Mathieu Othacehe
2020-11-27 16:54 ` [bug#44800] [PATCH v2 0/3] publish: Add Avahi support Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blfisozq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44800@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).