From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YAhrLMAzwV+BaAAA0tVLHw (envelope-from ) for ; Fri, 27 Nov 2020 17:13:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WBdeKMAzwV/XTAAAB5/wlQ (envelope-from ) for ; Fri, 27 Nov 2020 17:13:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 631BB940538 for ; Fri, 27 Nov 2020 17:13:36 +0000 (UTC) Received: from localhost ([::1]:35506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kihJP-0004YC-7G for larch@yhetil.org; Fri, 27 Nov 2020 12:13:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kihIs-0004Y2-Df for guix-patches@gnu.org; Fri, 27 Nov 2020 12:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kihIr-0001HH-VT for guix-patches@gnu.org; Fri, 27 Nov 2020 12:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kihIr-0007BS-QR for guix-patches@gnu.org; Fri, 27 Nov 2020 12:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44800] [PATCH v2 2/3] publish: Add avahi support. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Nov 2020 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44800 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 44800@debbugs.gnu.org Received: via spool by 44800-submit@debbugs.gnu.org id=B44800.160649715627585 (code B ref 44800); Fri, 27 Nov 2020 17:13:01 +0000 Received: (at 44800) by debbugs.gnu.org; 27 Nov 2020 17:12:36 +0000 Received: from localhost ([127.0.0.1]:46118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kihIS-0007Aq-HS for submit@debbugs.gnu.org; Fri, 27 Nov 2020 12:12:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kihIR-0007Ac-8q for 44800@debbugs.gnu.org; Fri, 27 Nov 2020 12:12:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54507) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kihIM-0001A1-4H for 44800@debbugs.gnu.org; Fri, 27 Nov 2020 12:12:30 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47908 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kihIJ-0008UV-6e; Fri, 27 Nov 2020 12:12:27 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201124132145.217751-1-othacehe@gnu.org> <20201124132145.217751-3-othacehe@gnu.org> Date: Fri, 27 Nov 2020 18:12:25 +0100 In-Reply-To: <20201124132145.217751-3-othacehe@gnu.org> (Mathieu Othacehe's message of "Tue, 24 Nov 2020 14:21:44 +0100") Message-ID: <87blfisozq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.77 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: 1U9Ir1VXxM+r Hi, Mathieu Othacehe skribis: > * guix/scripts/publish.scm (%options): Add "--enable-avahi" option. > (show-help): Document it. > (service-name): New procedure, > (publish-service-type): new variable. > (run-publish-server): Add "avahi?" and "port" parameters. Use them to pub= lish > the server using Avahi. > (guix-publish): Pass the "avahi?" option to "run-publish-server". > * gnu/services/base.scm (): Add "enable-avahi= ?" > field. > (guix-publish-shepherd-service): Honor it. Neat! > +When the @option{--enable-avahi} option is passed, the publish server is > +advertised on the local network as an Avahi service, using Guile-Avahi > +bindings. s/bindings/(@pxref{Top,,, guile-avahi, Using Avahi in Guile Scheme Programs= }/ As discussed on IRC, I would avoid using the name Avahi on the CLI and to some extent in the API as well. The command-line option could be =E2=80=9C--advertise=E2=80=9D. The documentation would be something like: =E2=80=A6 the server advertises its availability on the local network usi= ng multicast DNS (mDNS) and DNS service discovery (DNS-SD), currently @i{via} Guile-Avahi =E2=80=A6 (I remember that Julien posted a DNS client implementation a few years ago, we never know what the future will be like=E2=80=A6 :-)) > + (enable-avahi? guix-publish-enable-avahi? ;boolean > + (default #f)) Same here. > (define* (run-publish-server socket store > #:key > + avahi? port > (compressions (list %no-compression)) > (nar-path "nar") narinfo-ttl > cache pool) > + (when avahi? > + (avahi-publish-service-thread (service-name) > + #:type publish-service-type > + #:port port)) Maybe add (info (_ "advertising =E2=80=A6")) here. Ideally, you=E2=80=99d = need a callback because you can=E2=80=99t tell what the actual advertised name is = since Avahi can pick one to avoid name clashes. Thanks, Ludo=E2=80=99.