unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 49301@debbugs.gnu.org
Subject: [bug#49301] [PATCH 0/3] Give users control over file system checks.
Date: Wed, 07 Jul 2021 17:09:49 +0200	[thread overview]
Message-ID: <87bl7e40ua.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210630202018.19124-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Wed, 30 Jun 2021 22:20:16 +0200")


Hey Tobias,

Wooh, nice one! Did you actually manage to test all those options for
all the supported file-systems :) ?

> -(define* (mount-file-system fs #:key (root "/root"))
> +(define* (mount-file-system fs #:key (root "/root")
> +                            (check? (file-system-check? fs))
> +                            (skip-check-if-clean?
> +                             (file-system-skip-check-if-clean? fs))
> +                            (repair (file-system-repair fs)))

This seems to be duplicated ...

> +                    (mount-file-system fs
> +                                       #:check? (file-system-check? fs)
> +                                       #:skip-check-if-clean?
> +                                       (file-system-skip-check-if-clean? fs)
> +                                       #:repair (file-system-repair fs)))

... here. You could maybe provide empty defaults in the
"mount-file-system" procedure declaration, or on the contrary just use
those default in this call.

Otherwise this seems fine. If all the installation tests are passing,
you can go for it!

Thanks,

Mathieu




  parent reply	other threads:[~2021-07-07 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 20:15 [bug#49301] [PATCH 0/3] Give users control over file system checks Tobias Geerinckx-Rice via Guix-patches via
2021-06-30 20:20 ` [bug#49301] [PATCH 1/3] file-systems: Support forced checks & repairs Tobias Geerinckx-Rice via Guix-patches via
2021-06-30 20:20   ` [bug#49301] [PATCH 2/3] linux-boot: Honour fsck.mode & fsck.repair Tobias Geerinckx-Rice via Guix-patches via
2021-06-30 20:20   ` [bug#49301] [PATCH 3/3] gnu: Don't abuse check-btrfs-file-system to scan Tobias Geerinckx-Rice via Guix-patches via
2021-07-07 15:09   ` Mathieu Othacehe [this message]
2021-08-31 14:05     ` [bug#49301] [PATCH 0/3] Give users control over file system checks Mathieu Othacehe
2021-09-23 16:40 ` bug#49301: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl7e40ua.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=49301@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).