From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SGnoH0vE5WBGOwEAgWs5BA (envelope-from ) for ; Wed, 07 Jul 2021 17:12:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mNKSG0vE5WBtCwAA1q6Kng (envelope-from ) for ; Wed, 07 Jul 2021 15:12:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D56E322D00 for ; Wed, 7 Jul 2021 17:12:10 +0200 (CEST) Received: from localhost ([::1]:55302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m19Dd-0006Lj-QD for larch@yhetil.org; Wed, 07 Jul 2021 11:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m19CY-0003fM-FD for guix-patches@gnu.org; Wed, 07 Jul 2021 11:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m19CY-0007cA-7N for guix-patches@gnu.org; Wed, 07 Jul 2021 11:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m19CY-0001Wg-2C for guix-patches@gnu.org; Wed, 07 Jul 2021 11:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49301] [PATCH 0/3] Give users control over file system checks. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Jul 2021 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49301 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 49301@debbugs.gnu.org Received: via spool by 49301-submit@debbugs.gnu.org id=B49301.16256706055782 (code B ref 49301); Wed, 07 Jul 2021 15:11:02 +0000 Received: (at 49301) by debbugs.gnu.org; 7 Jul 2021 15:10:05 +0000 Received: from localhost ([127.0.0.1]:53239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19Bd-0001VC-GH for submit@debbugs.gnu.org; Wed, 07 Jul 2021 11:10:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19BX-0001Ua-CM for 49301@debbugs.gnu.org; Wed, 07 Jul 2021 11:10:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33064) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m19BR-0007Ro-Hz; Wed, 07 Jul 2021 11:09:53 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=43456 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m19BP-0002Pv-Mt; Wed, 07 Jul 2021 11:09:52 -0400 From: Mathieu Othacehe References: <87a6n7jef4.fsf@nckx> <20210630202018.19124-1-me@tobias.gr> Date: Wed, 07 Jul 2021 17:09:49 +0200 In-Reply-To: <20210630202018.19124-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Wed, 30 Jun 2021 22:20:16 +0200") Message-ID: <87bl7e40ua.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625670730; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=8Fo67n7oerOvt+95uKp+YS3R0rDP+FRMSJHl+EY4xNU=; b=js6dufFkN/UCmZEhGCnKY58GnAmyxmu7d94zXFZXMecbTr4Mq2brqV1uYs1gsNaJ6Lcoqd /OFMLpVssBmJrJ/woTfjDDWXkNYB94qoj5FtShNOm+Wed21KrBd5Ws194fJbmj+Cwnpf23 wk6yItrOhMTdkVXCDNkvaTvQcJy4NuLy7DPKQ2bueKy3hhw70KX6Ybu+InE7rd2clnbK1S NkX2x1ZrUoIzi4SlAOvngxxKVV4+x9/PI62KDES6wmXvcsJLVbuUoX3THxF//eS735yJE5 lYXuydzd7Gwe/+HD8hvkrMMYlSX1g1X8vrrJNWSIw0RfpSPhmKRuyfckrSe35Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625670731; a=rsa-sha256; cv=none; b=PNhUs6gA15AnHl7g5Dv3NKP4ZfCFnczy6wF9zLBgxbG8wcwSv3uoRU0BDqIib1THP2Aqjy JeLjqjFciDr2gmFx2s99bCEY9OstmaSMJe3gXPLQB0ax32vpShx11O0KZb9W9gCNb+2RZL 0e6t9PjHc7Q+Ptn2GJvfECAvvvceRYobmKLcYYtzVnd51bEUHUwebVLK/7TDzqLJPcMibR wlM7c+8wxpLo8TTlFdT4NIcav4xVAe8BB7ZaFD6Cpo0+C3XFDWywAC4jfw9iV0rYcwv06J fBOcIfxe3L5UfvnT6BgkN29G1CSDP2BOYJPw3qDyUI0MOiQXoJddOjo2Y1XJuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D56E322D00 X-Spam-Score: -1.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: FqDYqvS/zjvf Hey Tobias, Wooh, nice one! Did you actually manage to test all those options for all the supported file-systems :) ? > -(define* (mount-file-system fs #:key (root "/root")) > +(define* (mount-file-system fs #:key (root "/root") > + (check? (file-system-check? fs)) > + (skip-check-if-clean? > + (file-system-skip-check-if-clean? fs)) > + (repair (file-system-repair fs))) This seems to be duplicated ... > + (mount-file-system fs > + #:check? (file-system-check? fs) > + #:skip-check-if-clean? > + (file-system-skip-check-if-clean? fs) > + #:repair (file-system-repair fs))) ... here. You could maybe provide empty defaults in the "mount-file-system" procedure declaration, or on the contrary just use those default in this call. Otherwise this seems fine. If all the installation tests are passing, you can go for it! Thanks, Mathieu