unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49533@debbugs.gnu.org, Thorsten Wilms <t_w_@freenet.de>,
	Sarah Morgensen <iskarian@mgsn.dev>
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Date: Thu, 02 Sep 2021 09:56:44 +0200	[thread overview]
Message-ID: <87bl5b8l6r.fsf@elephly.net> (raw)
In-Reply-To: <874kcc28xz.fsf_-_@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

>> +   (native-search-paths
>> +    (list (search-path-specification
>> +           (variable "LV2_PATH")
>> +           (files '("lib/lv2")))))
>
> I’m surprised this is here (in the plugin) rather than in the 
> package
> that loads this plugin.  There are other LV2 plugins doing that 
> though.
> Ricardo, WDYT?

Yes, this looks wrong.

Plugins don’t need to set LV2_PATH; only hosts (such as Ardour, 
jalv, and others) do.  This must have been an early mistake that 
has been copied for other plugins.  None of the LV2 hosts that we 
offer set LV2_PATH.

-- 
Ricardo




  parent reply	other threads:[~2021-09-02  8:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  9:45 [bug#49533] [PATCH] gnu: Add omins-lv2 Thorsten Wilms
2021-07-22  4:15 ` Sarah Morgensen
2021-07-24 19:41   ` [bug#49533] [PATCH v2] " Thorsten Wilms
2021-07-29 19:53     ` [bug#49533] [PATCH] " Ludovic Courtès
2021-09-01 21:29       ` Ludovic Courtès
2021-09-02  8:03         ` Thorsten Wilms
2021-09-02  9:45           ` Ludovic Courtès
2021-09-02  8:56         ` [bug#49533] [PATCH v3] " Thorsten Wilms
2021-09-02  7:56       ` Ricardo Wurmus [this message]
2021-10-26 12:47 ` [bug#49533] [PATCH v4] " Thorsten Wilms
2024-02-25 12:15 ` bug#49533: [PATCH] " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl5b8l6r.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=49533@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=ludo@gnu.org \
    --cc=t_w_@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).