unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Thorsten Wilms <t_w_@freenet.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>,
	49533@debbugs.gnu.org, Sarah Morgensen <iskarian@mgsn.dev>
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Date: Thu, 2 Sep 2021 10:03:52 +0200	[thread overview]
Message-ID: <20210902100352.f45c5862e26068aea3467248@freenet.de> (raw)
In-Reply-To: <87y28g56j5.fsf_-_@gnu.org>

On Wed, 01 Sep 2021 23:29:18 +0200
Ludovic Courtès <ludo@gnu.org> wrote:

> Did you have a chance to look into this?

Hi Ludovic, I missed to notice your earlier email. Thanks for it and
this reminder!


> > Please consider passing it through ./etc/indent-code.el:
> >
> >   https://guix.gnu.org/manual/en/html_node/Formatting-Code.html

I assumed Emacs would do the right thing as is. My guix-installed Emacs
does not offer a guix-devel-mode. There’s also no ./etc/indent-code.el
on this foreign distro.


> > Please check out
> > <https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on
> > how to compute version numbers in such cases.

Done. Assuming the very last example shows the pattern to use, I
suspect that there are a lot of packages that should, but do not use
it. At least in audio.scm.


> >> +   (native-search-paths
> >> +    (list (search-path-specification
> >> +           (variable "LV2_PATH")
> >> +           (files '("lib/lv2")))))
> >
> > I’m surprised this is here (in the plugin) rather than in the
> > package that loads this plugin.  There are other LV2 plugins doing
> > that though. Ricardo, WDYT?

I mean to recall that this was necessary for the first lv2 package I
wrote, but from then on, I may have been cargo-culting. Since my
lilv and sord are still broken, no lv2-host will run. So I can’t even
test this now.


> >> +   (license (list license:gpl2+ license:gpl2+))))
> >
> > (license license:gpl2+) should be enough.  :-)

Sheesh, I did it again!

New patch version follows in separate email.


Thanks!

-- 
Thorsten Wilms <t_w_@freenet.de>




  reply	other threads:[~2021-09-02  8:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  9:45 [bug#49533] [PATCH] gnu: Add omins-lv2 Thorsten Wilms
2021-07-22  4:15 ` Sarah Morgensen
2021-07-24 19:41   ` [bug#49533] [PATCH v2] " Thorsten Wilms
2021-07-29 19:53     ` [bug#49533] [PATCH] " Ludovic Courtès
2021-09-01 21:29       ` Ludovic Courtès
2021-09-02  8:03         ` Thorsten Wilms [this message]
2021-09-02  9:45           ` Ludovic Courtès
2021-09-02  8:56         ` [bug#49533] [PATCH v3] " Thorsten Wilms
2021-09-02  7:56       ` [bug#49533] [PATCH] " Ricardo Wurmus
2021-10-26 12:47 ` [bug#49533] [PATCH v4] " Thorsten Wilms
2024-02-25 12:15 ` bug#49533: [PATCH] " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902100352.f45c5862e26068aea3467248@freenet.de \
    --to=t_w_@freenet.de \
    --cc=49533@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=ludo@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).