unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: "Paul A. Patience" <paul@apatience.com>
Cc: 54938-done@debbugs.gnu.org
Subject: bug#54938: Fw: Re: [bug#54938] [PATCH] gnu: sbcl-py4cl: Update to 0.0.0-1.2f2a008.
Date: Thu, 14 Apr 2022 18:35:00 +0000	[thread overview]
Message-ID: <87bkx3bjek.fsf@kitej> (raw)
In-Reply-To: <i9V5ubfNf_L2nIpBd68g8f06zVKlbt4nVAErorgFE2WKsFn7_ZvGkB1b43ZCYhtZ3PjBCFiZcDcJHYkO2dGK6gf-hBMVj6e4zNTNMBeDTwQ=@apatience.com>

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

"Paul A. Patience" <paul@apatience.com> skribis:

> (Forwarding my message since I accidentally didn't include 54938@debbugs.gnu.org
> in the "to" field.)
>
> On Thursday, April 14th, 2022 at 13:14, Paul A. Patience <paul@apatience.com> wrote:
>> On Thursday, April 14th, 2022 at 10:36, Guillaume Le Vaillant glv@posteo.net wrote:
>>> Is there a reason to update only to commit 2f2a008 from September 2019
>>> instead of a more recent one?
>>
>> The latest commit (from February 2021) has several issues originating from
>> the backports from digikar99's py4cl2 package.
>> For example, the py-cd function does not follow the naming scheme of py4cl,
>> and also calls the inexistent pycall function (pycall is py4cl2's equivalent
>> of py4cl's python-call).
>>
>> Further, a configuration file was introduced to configure several things,
>> including the path to python and some configuration variables related to
>> numpy array pickling.
>> The problem is the configuration file has to be located in the same
>> (writable) directory as py4cl.py, which of course causes problems with Guix.
>> Technically this isn't an issue because Guix hardcodes the path to py4cl.py,
>> so we could reuse *base-directory* for just the configuration file, but I think
>> a better solution would be to put the configuration file into XDG_CONFIG_HOME,
>> and that is probably better fixed at the source rather than in the Guix package.
>>
>> The test suite fails as well, perhaps due to the configuration file not being
>> writable.
>> I didn't investigate very much.
>>
>> I may submit some fixes to py4cl in the future for the issues I mentioned,
>> but only if I keep using it (at the moment I am evaluating its suitability).
>> Until then, the commit I've updated sbcl-py4cl to is the last before the first
>> of digikar99's changes were merged.
>>
>> Best regards,
>> Paul

Ok, thanks for the explanation. Patch pushed as
5059e7f01e1d299a2a52b1649251fa49f1992385.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-04-14 18:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 14:07 [bug#54938] [PATCH] gnu: sbcl-py4cl: Update to 0.0.0-1.2f2a008 Paul A. Patience
2022-04-14 14:36 ` Guillaume Le Vaillant
     [not found]   ` <-pXFOD8i64LooBxxS-zlALDS97M9U1WyY-kCqpvFQL7WDDO2IKPofQy8PJdzmRlGObTocXAEtgXVgIihw3ugR49OiwS5qZOO-Ez9OKHYynA=@apatience.com>
2022-04-14 18:26     ` [bug#54938] Fw: " Paul A. Patience
2022-04-14 18:35       ` Guillaume Le Vaillant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkx3bjek.fsf@kitej \
    --to=glv@posteo.net \
    --cc=54938-done@debbugs.gnu.org \
    --cc=paul@apatience.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).