unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Pavel Shlyak <p.shlyak@pantherx.org>
Cc: 55663@debbugs.gnu.org
Subject: [bug#55663] [PATCH] Image API: add FAT32 support
Date: Thu, 26 May 2022 20:07:56 +0200	[thread overview]
Message-ID: <87bkvk6tp0@nckx> (raw)
In-Reply-To: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org>

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Pavel,

Pavel Shlyak 写道:
> I believe it is an important change as Raspberry PI (and I 
> suppose some other boards) cannot boot with fat16 boot 
> partitions. 

LGTM in principle.

The FS_BITS argument should be a regular number.  You can coerce 
it with number->string in the command line.

On the subject of being explicit is good: we should add "fat16" 
type and treat "vfat" as a softly deprecated alias.  But that can 
be done in a later patch.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-05-26 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 18:02 [bug#55663] [PATCH] Image API: add FAT32 support Pavel Shlyak
2022-05-26 18:07 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2022-05-26 20:54   ` Pavel Shlyak
2022-05-29 11:46     ` Pavel Shlyak
2022-05-29 14:35 ` Pavel Shlyak
2022-05-30  7:01   ` Mathieu Othacehe
2022-05-30  9:01     ` Pavel Shlyak
2022-05-31 13:07       ` bug#55663: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkvk6tp0@nckx \
    --to=guix-patches@gnu.org \
    --cc=55663@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=p.shlyak@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).