From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OBQ3IlDFj2LyfwAAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 20:22:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WNk+IVDFj2KHMgEAG6o9tA (envelope-from ) for ; Thu, 26 May 2022 20:22:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 271C12A186 for ; Thu, 26 May 2022 20:22:07 +0200 (CEST) Received: from localhost ([::1]:49712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuI7a-0003ch-Bn for larch@yhetil.org; Thu, 26 May 2022 14:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuI7W-0003cS-2s for guix-patches@gnu.org; Thu, 26 May 2022 14:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuI7V-0001Tn-Qn for guix-patches@gnu.org; Thu, 26 May 2022 14:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuI7V-0008EK-KY for guix-patches@gnu.org; Thu, 26 May 2022 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pavel Shlyak Cc: 55663@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 55663@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165358930231610 (code B ref -1); Thu, 26 May 2022 18:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 18:21:42 +0000 Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuI7C-0008Dl-4j for submit@debbugs.gnu.org; Thu, 26 May 2022 14:21:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:57204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuI7A-0008De-Mn for submit@debbugs.gnu.org; Thu, 26 May 2022 14:21:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuI7A-0003c2-Hk for guix-patches@gnu.org; Thu, 26 May 2022 14:21:40 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:53548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuI77-0001Sn-3u for guix-patches@gnu.org; Thu, 26 May 2022 14:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=NJV9QLX7QjIVe 0YsqMgo6f/QgV2CpTCTV2s2EhBIBSE=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=QmJDYetI825KZYJLtWtbZ/01AyOuNsv3NtE8EB NJ2j74sEldA6IHbvyQc+U/ZnLDucR/oHgAmwbGZHTIqmPO1nU740Er22p0OQ3aDcvdbvcL VuITN8uOokPFTsc0mX7J8rWRFl+kKV4j1X3YFmngeUIj7YLFHlf9Bxs6Gz28wLXu7OqY2u s/PhqgxP8GaE7gRDJGc0oWJqXNSYbFgW9yorXgkmKsVBwrVJ832JYb2gXAPmQnZLP4a0+a vek3M+E+x3LUXuSkZt2k4eZfNl/rrs5goDGMqpI2BTuYGC/qNSmYul7eZ3DCZFfMtrGH6A pThZxJHJUrlRpwlf/RKCZM0w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 64dc39f4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 26 May 2022 18:21:32 +0000 (UTC) References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> Date: Thu, 26 May 2022 20:07:56 +0200 In-reply-to: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkvk6tp0@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653589328; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NJV9QLX7QjIVe0YsqMgo6f/QgV2CpTCTV2s2EhBIBSE=; b=rQ7Rx2vqOSXTV81gPbG0Hk2Scia7OcyeEGtUFKq+qysQ+/N5R2aXdxeC1qaR8tL/iLG93g lzB9a4J93/CQfn6Y4DEQZsE+jyC+TRgKeiru4QmsgiysgAJVjFiNRpISDCiVaB5k5Q3/zn VXafey5Zzg6zcLPL2xV0bf4rNnVC+bFq86oOw4lOm2wHC8eeGeMfpGls11Ffk7Kew9s99W 8aeTijMwCXDfy5Z9sahEDcAkPBjRpnNQLU+s10w21y6NhO3y3V8zTCMtFeZZrjLTXVBFDs X9cP4qIZz2FuKz2LHCbfGmf8ouMxCM/NcraOcx0QrtOHjCNq5lS/O2HcCajw8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653589328; a=rsa-sha256; cv=none; b=bswt+4DgFxv780wgstzdpj5bRm2J0QJX3wAegiESb+qf9/WvzP0tWMgQWX/baYuRr5psBz a8QUrPChr2XjW3d8jRb7yFRRV3vFbKvVE4GaICKinagwbBMGY0pBZAFeJApzdWFFw09CDM wbz+jOa+b8UAHlN3kp+E2B4Y3bIMMZpCS7SRpSa+a39A8LgD1uQeIagsN/+vVlhYkyYdRv QtLa7XC8wHKvOoHHAaLW8Ost/2pAgnAXYao7gTy31ZafKwdBtCK4Xh7gVraYsQG1NbGSh2 NhWnnEa3H9cyq97Mwg6Iu91FCsCaolOyNmhvky3MgujFqKjSkhHTLoIplI/igw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=QmJDYetI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=QmJDYetI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 271C12A186 X-Spam-Score: -3.84 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8S9Ivv3X+0fM --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Pavel, Pavel Shlyak =E5=86=99=E9=81=93=EF=BC=9A > I believe it is an important change as Raspberry PI (and I=20 > suppose some other boards) cannot boot with fat16 boot=20 > partitions.=20 LGTM in principle. The FS_BITS argument should be a regular number. You can coerce=20 it with number->string in the command line. On the subject of being explicit is good: we should add "fat16"=20 type and treat "vfat" as a softly deprecated alias. But that can=20 be done in a later patch. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYo/FKw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15v/oA/0mmvcJbt4k2Qt186TpOF7ig4VrZm+zMDIoOyjLV yC58AP4+iXSPi6tjXd8+Ya6adpJVdFx2Hz9xbpxJ9pv3M7F+BA== =jX82 -----END PGP SIGNATURE----- --=-=-=--