unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Abhishek Cherath <abhi@quic.us>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
	69971@debbugs.gnu.org, Vivien Kraus <vivien@planete-kraus.eu>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively.
Date: Sun, 31 Mar 2024 21:33:41 -0400	[thread overview]
Message-ID: <87bk6tx3wq.fsf@gmail.com> (raw)
In-Reply-To: <43974b799a22fd2b469494040b2ff02335f92315.1711259689.git.abhi@quic.us> (Abhishek Cherath's message of "Sun, 24 Mar 2024 01:54:50 -0400")

Hello!

Abhishek Cherath <abhi@quic.us> writes:

> * gnu/packages/patches/webkitgtk-adjust-bubblewrap-paths.patch:
> Add @dridir@ and @localedir@ to bubblewrap gtk sandbox
> * gnu/packages/webkit.scm (webkitgtk)[arguments]: In the
> 'configure-bubblewrap-store-directory' phase, also supply locale
> and dri directory paths to webkitgtk-adjust-bubblewrap-paths.patch
> template.

This looks reasonable to me, thanks for your contribution!  I suppose
for security reasons the file names must be static, e.g. cannot be
$HOME/.guix-profile/share/locale or similar?

LGTM; Liliana, I remember you would prefer not having webkitgtk changes
happen on master; do you have a suggestion of which branch this should
be committed to?  gnome-team?

-- 
Thanks,
Maxim




  reply	other threads:[~2024-04-01  1:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-24  2:02 [bug#69971] [PATCH] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively Abhishek Cherath
2024-03-24  5:54 ` [bug#69971] [PATCH v2] " Abhishek Cherath
2024-04-01  1:33   ` Maxim Cournoyer [this message]
2024-04-01  2:17     ` Abhishek Cherath
2024-04-01  6:32       ` Liliana Marie Prikler
2024-04-01 10:49         ` Abhishek Cherath
2024-04-01 17:05           ` Liliana Marie Prikler
2024-04-01 18:11             ` Jack Hill
2024-04-01 18:20               ` Liliana Marie Prikler
2024-04-01 18:28                 ` Abhishek Cherath
2024-03-24  6:24 ` [bug#69971] Explanation Abhishek Cherath
2024-03-24 21:22 ` [bug#69971] Some more information Abhishek Cherath
2024-03-24 21:26   ` Abhishek Cherath
2024-04-18  3:09 ` [bug#69971] Submitted to gnome-team Abhishek Cherath
2024-04-18  3:14 ` [bug#69971] close 69971 Abhishek Cherath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk6tx3wq.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=69971@debbugs.gnu.org \
    --cc=abhi@quic.us \
    --cc=liliana.prikler@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).