unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Abhishek Cherath <abhi@quic.us>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
	69971@debbugs.gnu.org, Vivien Kraus <vivien@planete-kraus.eu>
Subject: [bug#69971] [PATCH v2] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively.
Date: Mon, 01 Apr 2024 19:05:01 +0200	[thread overview]
Message-ID: <1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@gmail.com> (raw)
In-Reply-To: <32CEBDAB-81B8-4B75-8B2A-69BEA6512B71@quic.us>

Am Montag, dem 01.04.2024 um 06:49 -0400 schrieb Abhishek Cherath:
> > I think dynamic choices should be possible – IIRC, std::strings are
> > used for arguments, but even if not, we're dealing with C++, so we
> > can allocate "on the stack".
> 
> 👍. I can make that change tomorrow. One QoL thing. How do you run a
> program built in /tmp/<<build_folder>> without it complaining about
> store paths and suchlike?
> 
> I ask because ideally, I'd debug this by interrupting the webkit
> build somewhere while I have --keep-failed, then `guix shell -D
> webkitgtk --pure && . environment-variables`, then running the
> minibrowser. But that doesn't work because it complains about stuff
> not being in the store.
> 
> Oh, but I suppose I could use LD_LIBRARY_PATH unless it compiles in
> some strings.  Will try.
You should be able to run things from the build folder, but you could
also throw a post-install error if needed.  Just note that webkitgtk in
and of itself doesn't really come with a full browser, so you'd have to
compile one as well…

I think with webkit in particular the problem is that store paths are
getting hard-coded in places where file existence is required, so you
might want to replace those store paths with /tmp/guix-build/…

> > rebuilds from 44.10.  I'd prefer if stuff that rebuilds webkitgtk
> > on master were grafted, as it causes more than the prescribed 300
> > rebuilds and is a nasty build itself.
> 
> 👍, so call this webkitgtk-bubblewrap-fixed and have a replacement
> field in the other package?
Ahh, sorry, grafts are for security purposes – changes like these would
have to go through the usual channels (i.e. gnome-team).  We will be
jumping ahead to 46 at some point in the future, but for now the branch
is chill and we still need to catch up on stuff we missed for master.

Cheers




  reply	other threads:[~2024-04-01 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-24  2:02 [bug#69971] [PATCH] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively Abhishek Cherath
2024-03-24  5:54 ` [bug#69971] [PATCH v2] " Abhishek Cherath
2024-04-01  1:33   ` Maxim Cournoyer
2024-04-01  2:17     ` Abhishek Cherath
2024-04-01  6:32       ` Liliana Marie Prikler
2024-04-01 10:49         ` Abhishek Cherath
2024-04-01 17:05           ` Liliana Marie Prikler [this message]
2024-04-01 18:11             ` Jack Hill
2024-04-01 18:20               ` Liliana Marie Prikler
2024-04-01 18:28                 ` Abhishek Cherath
2024-03-24  6:24 ` [bug#69971] Explanation Abhishek Cherath
2024-03-24 21:22 ` [bug#69971] Some more information Abhishek Cherath
2024-03-24 21:26   ` Abhishek Cherath
2024-04-18  3:09 ` [bug#69971] Submitted to gnome-team Abhishek Cherath
2024-04-18  3:14 ` [bug#69971] close 69971 Abhishek Cherath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c0548fce1e731b0b9c7a139ac887a89f9854932.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=69971@debbugs.gnu.org \
    --cc=abhi@quic.us \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).